TypeAdapters support (#95) #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncapat
force-pushed
the
adapters_rolling
branch
from
cf898bf to
19dbcec
Compare
|
@gbiggs may I ask you a preliminary feedback? Or simply if is there something more I could do to push forward this patch :) |
|
@clalancette I saw by the commits you are active also in this repo (sorry to disturb you though). May I ask you at least a preliminary feedback on this? |
|
Any updates on this? Is there something I can do? |
clalancette
approved these changes
Jul 13, 2023
|
CI:
|
|
@clalancette can this be backported to Iron as well? |
roncapat
added a commit
to Fixit-Davide/message_filters
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #95.
This patch allows to use Type Adaptation within message_filters.
A requirement for the adapted native structure is to feature an header attribute like ROS messages usually do.