Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transition start and goal states can be null #662

Merged
merged 2 commits into from
May 27, 2020
Merged

transition start and goal states can be null #662

merged 2 commits into from
May 27, 2020

Conversation

Karsten1987
Copy link
Contributor

The lifecycle transitions can be lazy initialized, meaning that the start and goal state can be null at the time of initialization: https://github.com/ros2/rclcpp/blob/87bb9f9758dce239d37256ae91d58ce6325f405b/rclcpp_lifecycle/src/transition.cpp#L155-L156

This should fix the regression stated in here; #649 (comment)

@Karsten1987
transition start and goal states can be null
b9abc7e 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987 Karsten1987 self-assigned this May 27, 2020
@Karsten1987
Copy link
Contributor Author

CI: (building up to rclcpp_lifeycycle, testing rcl_lifecycle & rclcpp_lifecycle):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
correct tests
93dd1ad 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
Copy link
Contributor Author

didn't push the adaptions of the tests correctly. once more:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member

ivanpauno commented May 27, 2020 •
edited
Loading

rclcpp_lifecycle.TestDefaultStateMachine.check_parameters is still failing, the current changes LGTM

@Karsten1987
Copy link
Contributor Author

I believe these are related to ros2/rclcpp#1134 (comment)

I don't think they are related to the changes in rcl_lifecycle.

@ivanpauno
Copy link
Member

I believe these are related to ros2/rclcpp#1134 (comment)

I don't think they are related to the changes in rcl_lifecycle.

Lovely ❤️

brawner
brawner approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this Karsten!

@Karsten1987 Karsten1987 merged commit 0de31d0 into master May 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the transition_lazy_init branch May 27, 2020 19:03
@ivanpauno ivanpauno mentioned this pull request May 27, 2020
Merged
@ivanpauno
Copy link
Member

I believe these are related to ros2/rclcpp#1134 (comment)

I don't think they are related to the changes in rcl_lifecycle.

Proposed fix in ros2/rclcpp#1136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brawner brawner brawner approved these changes

@hidmic hidmic hidmic approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@Karsten1987 Karsten1987

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Karsten1987 @ivanpauno @brawner @hidmic