Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_lifecycle_node.cpp:check_parameters #1136

Merged
merged 2 commits into from
May 27, 2020
Merged

Fix test_lifecycle_node.cpp:check_parameters #1136

merged 2 commits into from
May 27, 2020

Conversation

ivanpauno
Copy link
Member

No description provided.

@ivanpauno
Fix test_lifecycle_node.cpp:check_parameters
4528ef2 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
style
6f7af74 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added bug Something isn't working in review Waiting for review (Kanban column) labels May 27, 2020
@ivanpauno ivanpauno self-assigned this May 27, 2020
This was referenced May 27, 2020
Merged
Merged
Karsten1987
Karsten1987 approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me (with green CI)

jacobperron
jacobperron approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanpauno
Copy link
Member Author

ivanpauno commented May 27, 2020 •
edited
Loading

CI:

@ivanpauno ivanpauno merged commit eff11d6 into master May 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-failure-lifecycle-node-param-callback-test branch May 27, 2020 19:59
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Jul 7, 2020
@ivanpauno
Fix test_lifecycle_node.cpp:check_parameters (ros2#1136)
e72a6a7 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@scpeters scpeters mentioned this pull request Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@claireyywang claireyywang Awaiting requested review from claireyywang

Assignees

@ivanpauno ivanpauno

Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanpauno @jacobperron @Karsten1987