Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop rclpy test_remove_ros_args_empty test case. #445

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Drop rclpy test_remove_ros_args_empty test case. #445

merged 1 commit into from
Oct 17, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Oct 17, 2019

Follow-up PR after ros2/rcl#518.

@hidmic
Drop rclpy test_remove_ros_args_empty test case.
f394c33 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Oct 17, 2019 •
edited
Loading

CI (up to rclcpp and rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

mjcarroll
mjcarroll approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

BMarchi
BMarchi approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@BMarchi BMarchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thingy made CI fail for my PR

@BMarchi BMarchi mentioned this pull request Oct 17, 2019
Merged
@mabelzhang mabelzhang added the enhancement New feature or request label Oct 17, 2019
@hidmic
Copy link
Contributor Author

hidmic commented Oct 17, 2019

Going in!

@hidmic hidmic merged commit 7366b76 into master Oct 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/no-args-to-remove-is-not-an-error branch October 17, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BMarchi BMarchi BMarchi approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hidmic @mjcarroll @BMarchi @mabelzhang