Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] Use absolute parameter events topic name (#612) #614

Merged
merged 1 commit into from
Nov 6, 2020
Merged

[foxy backport] Use absolute parameter events topic name (#612) #614

merged 1 commit into from
Nov 6, 2020

Conversation

jacobperron
Copy link
Member

Backport #612 to Foxy.

@ivanpauno @jacobperron
Use absolute parameter events topic name (#612)
e327e14 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@jacobperron jacobperron self-assigned this Aug 6, 2020
@jacobperron jacobperron added the bug Something isn't working label Aug 6, 2020
@jacobperron jacobperron mentioned this pull request Aug 6, 2020
Merged
@jacobperron
Copy link
Member Author

jacobperron commented Oct 1, 2020 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status (unrelated failures)
  • Windows Build Status (edit: retriggered)

@sloretz
Copy link
Contributor

sloretz commented Nov 5, 2020

@jacobperron are the windows CI failures unrelated too?

@jacobperron
Copy link
Member Author

jacobperron commented Nov 5, 2020 •
edited
Loading

I'm not sure about the Windows failures, triggering a regular Foxy job for comparison: Build Status

@jacobperron
Copy link
Member Author

I'm pretty sure all the windows failures are unrelated. The only one that I don't recall seeing before is this demo_nodes_cpp failure, but it looks like timeouts in the demo_nodes_cpp tests have happened recently on Windows with Connext: https://ci.ros2.org/view/nightly/job/nightly_win_rep/2055/testReport/junit/demo_nodes_cpp/TestExecutablesTutorial/test_processes_output/

@jacobperron jacobperron merged commit 72ab150 into foxy Nov 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/backport_612 branch November 6, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@jacobperron jacobperron

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @sloretz @ivanpauno