Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes ros_timer_init for ros_timer_init2 #999

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Changes ros_timer_init for ros_timer_init2 #999

merged 2 commits into from
Jun 21, 2023

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Sep 1, 2022

This PR is a follow up of rcl#1004 and should be merged after that PR is merged.

Signed-off-by: Voldivh eloyabmfcv@gmail.com

@Voldivh
Modifies ros_timer_init for ros_timer_init2
ade364a 
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@Voldivh Voldivh changed the title Modifies ros_timer_init for ros_timer_init2 Changes ros_timer_init for ros_timer_init2 Sep 1, 2022
@Voldivh Voldivh marked this pull request as ready for review September 1, 2022 15:26
@Voldivh Voldivh mentioned this pull request Sep 1, 2022
Merged
@tgroechel tgroechel mentioned this pull request Jun 2, 2023
Closed
fujitatomoya
fujitatomoya requested changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not change user experience with autostart flag for rclpy, i would recommend that rclpy as the same option as a counterpart of ros2/rclcpp#2005

This was referenced Jun 14, 2023
Merged
Merged
@emersonknapp
Copy link
Contributor

Pulls: ros2/rcl#1004, ros2/rclcpp#2005, ros2/system_tests#508, #999
Gist: https://gist.githubusercontent.com/emersonknapp/f9353e435d78a1ff796a38b74eaf0547/raw/2a9e6c7645332dcc2c4a6d0fb6f7b66e6b428bb7/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rcl_action rclcpp rclpy test_rclcpp
TEST args: --packages-above rcl rcl_action rclcpp rclpy test_rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12240

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

CI is green, see ros2/rcl#1004 (comment)

@fujitatomoya
Copy link
Collaborator

@Voldivh

This does not change user experience with autostart flag for rclpy, i would recommend that rclpy as the same option as a counterpart of ros2/rclcpp#2005

you are not gonna implement this at this time? maybe this would be follow-up task for rclpy?

@Voldivh
Copy link
Contributor Author

Voldivh commented Jun 15, 2023

This does not change user experience with autostart flag for rclpy, i would recommend that rclpy as the same option as a counterpart of ros2/rclcpp#2005

Taking into account the chain of PR's given this one ros2/rcl#1004 . Would it be ok if we address this comment in a different PR?

@clalancette clalancette merged commit 739e05b into ros2:rolling Jun 21, 2023
@Voldivh Voldivh deleted the voldivh/autostart branch June 21, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@emersonknapp emersonknapp emersonknapp approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Voldivh @emersonknapp @fujitatomoya @clalancette