Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one participant per context API changes #77

Merged
merged 6 commits into from
Apr 3, 2020
Merged

Use one participant per context API changes #77

merged 6 commits into from
Apr 3, 2020

Conversation

ivanpauno
Copy link
Member

Minimal renaming as part of ros2/rmw#183.

@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Dec 18, 2019
@ivanpauno ivanpauno self-assigned this Dec 18, 2019
@ivanpauno ivanpauno changed the title Rename rmw_security_options_t Rename rmw_node_security_options_t Dec 18, 2019
@ivanpauno ivanpauno mentioned this pull request Dec 18, 2019
Closed
6 tasks
@ivanpauno ivanpauno force-pushed the ivanpauno/one-participant-per-context branch from 4d6172a to 9b9bdce Compare January 28, 2020 16:10
hidmic
hidmic reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending another reviewer pass

@ivanpauno ivanpauno force-pushed the ivanpauno/one-participant-per-context branch from 9b9bdce to ff35c4e Compare February 6, 2020 20:57
@ivanpauno ivanpauno changed the title Rename rmw_node_security_options_t Update after one Participant per Context refactor Mar 2, 2020
@ivanpauno ivanpauno requested a review from hidmic March 2, 2020 12:20
@hidmic
Copy link
Contributor

hidmic commented Mar 2, 2020

Still waiting for CI

@ivanpauno
Rename rmw_security_options_t
d7a0ccd 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add rmw_use_node_name_in_security_directory_lookup function
c760d4c 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Please uncrustify
d549cdd 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Changes after last update about sros2
c2044a4 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Delete unused function
0d9ba2c 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Naming: replace context_name with security_context
1ff2c42 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/one-participant-per-context branch from 9cfe775 to 1ff2c42 Compare March 19, 2020 21:36
@ivanpauno ivanpauno requested a review from hidmic March 25, 2020 17:54
hidmic
hidmic approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanpauno ivanpauno mentioned this pull request Apr 2, 2020
Merged
@ivanpauno ivanpauno changed the title Update after one Participant per Context refactor Use one participant per context API changes Apr 3, 2020
@ivanpauno ivanpauno merged commit 8097e61 into master Apr 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/one-participant-per-context branch April 3, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @hidmic