Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raspimouse_description which is moved to another repository #42

Merged
merged 4 commits into from
May 25, 2020

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented May 20, 2020

What does this implement/fix? Explain your changes.

raspimouse_descriptionhttps://github.com/rt-net/raspimouse_description に移行したので raspimouse_sim からは削除します。

Does this close any currently open issues?

close #36

How has this been tested?

https://github.com/Tiryoh/docker_ros-desktop-vnc を用いて以下の通り実行してシミュレータが起動することを確認しています。

cd ~/catkin_ws/src
git clone https://github.com/rt-net/raspimouse_sim.git
git clone https://github.com/rt-net/raspimouse_description.git
(cd ~/catkin_ws/src/raspimouse_sim  && git checkout issue/36/separate_description)
rosdep install -r -y -i --from-paths raspimouse*
catkin build
catkin source
roslaunch raspimouse_gazebo raspimouse_with_samplemaze.launch use_devfile:=false

Checklists

  • I have read the CONTRIBUTING document.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@Tiryoh Tiryoh changed the title Issue/36/separate description Remove raspimouse_description May 20, 2020
@Tiryoh Tiryoh changed the title Remove raspimouse_description Remove raspimouse_description which is moved to another repository May 20, 2020
@Tiryoh Tiryoh self-assigned this May 20, 2020
@Tiryoh Tiryoh added the Type: Breaking Change Includes breaking changes label May 20, 2020
@Tiryoh Tiryoh marked this pull request as ready for review May 21, 2020 03:07
@Tiryoh Tiryoh assigned ShotaAk and unassigned Tiryoh May 21, 2020
@Tiryoh Tiryoh requested a review from ShotaAk May 21, 2020 03:07
@Tiryoh Tiryoh added this to the Release 1.0.0 milestone May 21, 2020
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作確認しました。OKです。

@ShotaAk
Copy link

ShotaAk commented May 25, 2020

Wikiの修正が必要なのでissueを立てました。
#48

@ShotaAk ShotaAk merged commit 6aa60f3 into master May 25, 2020
@Tiryoh Tiryoh deleted the issue/36/separate_description branch May 25, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Includes breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

独立したraspimouse_descriptionを使用する
2 participants