Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] Change locate_working_dir to be breadth-first. #908

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[breaking] Change locate_working_dir to be breadth-first. #908

merged 1 commit into from
Jun 20, 2024

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Jun 18, 2024 •
edited
Loading

  • Enabled unit test for search
  • Moved these search functions out of RNSClient into normal helpers
  • Changed to first breadth first for normal things indicating "projects" and then for the rh directory, which could be put... kind of anywhere. We should probably rid ourselves of depending on this.

@rohinb2 Graphite App
Copy link
Contributor Author

rohinb2 commented Jun 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on Graphite Graphite

@rohinb2 rohinb2 changed the title Change locate_working_dir logic to be breadth first. Remove locate_working_dir from rns_client Jun 18, 2024
@rohinb2 rohinb2 changed the title Remove locate_working_dir from rns_client Change locate_working_dir to be breadth-first. Jun 18, 2024
@rohinb2 rohinb2 marked this pull request as ready for review June 18, 2024 16:17
@rohinb2 rohinb2 force-pushed the 06-18-Change_locate_working_dir_logic_to_be_breadth_first branch from a687cb2 to 633e47c Compare June 18, 2024 16:21
This was referenced Jun 18, 2024
Merged
Merged
Merged
@rohinb2 rohinb2 force-pushed the 06-18-Change_locate_working_dir_logic_to_be_breadth_first branch from 633e47c to 7a957dd Compare June 19, 2024 02:04
@rohinb2 rohinb2 changed the base branch from main to 06-18-Propagate_self.env_if_it_was_set June 19, 2024 02:04
@rohinb2 rohinb2 mentioned this pull request Jun 19, 2024
Merged
@rohinb2 rohinb2 changed the title Change locate_working_dir to be breadth-first. [breaking] Change locate_working_dir to be breadth-first. Jun 20, 2024
@rohinb2 Graphite App
Copy link
Contributor Author

rohinb2 commented Jun 20, 2024 •
edited
Loading

Merge activity

  • Jun 20, 2:47 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Jun 20, 2:50 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 20, 2:51 PM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 force-pushed the 06-18-Propagate_self.env_if_it_was_set branch from a83956c to bc446aa Compare June 20, 2024 18:48
Base automatically changed from 06-18-Propagate_self.env_if_it_was_set to main June 20, 2024 18:49
@rohinb2 rohinb2 force-pushed the 06-18-Change_locate_working_dir_logic_to_be_breadth_first branch from 7a957dd to 937e957 Compare June 20, 2024 18:49
@rohinb2 rohinb2 merged commit f320af1 into main Jun 20, 2024
12 checks passed
@rohinb2 rohinb2 deleted the 06-18-Change_locate_working_dir_logic_to_be_breadth_first branch June 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohinb2