Remove defaulting working_dir to ./.
#915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 18, 2024
rohinb2
force-pushed
the
06-18-Add_module_pointers_to_env_if_they_don_t_exist
branch
from
7abc53f to
a0513d9
Compare
rohinb2
force-pushed
the
06-18-Remove_defaulting_working_dir_to_./_
branch
from
79c190b to
eb17c39
Compare
rohinb2
force-pushed
the
06-18-Add_module_pointers_to_env_if_they_don_t_exist
branch
from
a0513d9 to
bd55a56
Compare
rohinb2
force-pushed
the
06-18-Remove_defaulting_working_dir_to_./_
branch
from
eb17c39 to
d649fdd
Compare
rohinb2
force-pushed
the
06-18-Add_module_pointers_to_env_if_they_don_t_exist
branch
from
bd55a56 to
0495161
Compare
rohinb2
force-pushed
the
06-18-Remove_defaulting_working_dir_to_./_
branch
from
d649fdd to
a73815e
Compare
rohinb2
force-pushed
the
06-18-Add_module_pointers_to_env_if_they_don_t_exist
branch
from
0495161 to
7c7befc
Compare
rohinb2
force-pushed
the
06-18-Remove_defaulting_working_dir_to_./_
branch
3 times, most recently
from
43b3c6c to
52f4309
Compare
rohinb2
force-pushed
the
06-18-Add_module_pointers_to_env_if_they_don_t_exist
branch
from
7c7befc to
3f27e5e
Compare
rohinb2
force-pushed
the
06-18-Remove_defaulting_working_dir_to_./_
branch
from
52f4309 to
22f29d4
Compare
rohinb2
force-pushed
the
06-18-Add_module_pointers_to_env_if_they_don_t_exist
branch
from
3f27e5e to
cf4d086
Compare
rohinb2
force-pushed
the
06-18-Remove_defaulting_working_dir_to_./_
branch
from
22f29d4 to
9fb1a43
Compare
rohinb2
force-pushed
the
06-18-Add_module_pointers_to_env_if_they_don_t_exist
branch
from
cf4d086 to
5609234
Compare
rohinb2
force-pushed
the
06-18-Remove_defaulting_working_dir_to_./_
branch
from
9fb1a43 to
5996f96
Compare
rohinb2
changed the base branch from
06-18-Add_module_pointers_to_env_if_they_don_t_exist
to
06-25-Fix_bug_in__run_commands_with_ssh_where_node_is_not_set
| @@ -34,7 +34,7 @@ def env( | |||
| env_vars (Dict or str): Dictionary of environment variables, or relative path to .env file containing | |||
| environment variables. (Default: {}) | |||
| working_dir (str or Path): Working directory of the environment, to be loaded onto the system. | |||
| (Default: "./") | |||
| (Default: None) | |||
There was a problem hiding this comment.
Maybe mark as deprecated?
rohinb2
force-pushed
the
06-25-Fix_bug_in__run_commands_with_ssh_where_node_is_not_set
branch
from
2434d0c to
a38661e
Compare
Base automatically changed from
06-25-Fix_bug_in__run_commands_with_ssh_where_node_is_not_set
to
main
June 25, 2024 19:34
rohinb2
force-pushed
the
06-18-Remove_defaulting_working_dir_to_./_
branch
from
5996f96 to
71a9162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass working_dir as ./, it'll still work and run the detection algorithm. However, omit it by default, as when the module or function is actually sent to the env, then the working_dir is automatically added based on the file where the code was.