Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module pointers to env if they don't exist. #914

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add module pointers to env if they don't exist. #914

merged 1 commit into from
Jun 25, 2024

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Jun 18, 2024

No description provided.

@rohinb2 rohinb2 mentioned this pull request Jun 18, 2024
Merged
@rohinb2 Graphite App
Copy link
Contributor Author

rohinb2 commented Jun 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on Graphite Graphite

This was referenced Jun 18, 2024
Merged
Merged
@rohinb2 rohinb2 force-pushed the 06-18-_minor_simplify_Folder_path_logic branch from 60ca02b to 1cda7f1 Compare June 19, 2024 02:04
@rohinb2 rohinb2 force-pushed the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch from 7abc53f to a0513d9 Compare June 19, 2024 02:04
@rohinb2 rohinb2 mentioned this pull request Jun 19, 2024
Merged
@rohinb2 rohinb2 force-pushed the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch from a0513d9 to bd55a56 Compare June 19, 2024 02:18
@rohinb2 rohinb2 force-pushed the 06-18-_minor_simplify_Folder_path_logic branch from 1cda7f1 to eb4b9ba Compare June 20, 2024 18:51
Base automatically changed from 06-18-_minor_simplify_Folder_path_logic to main June 20, 2024 18:53
@rohinb2 rohinb2 force-pushed the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch from bd55a56 to 0495161 Compare June 20, 2024 21:36
@rohinb2 rohinb2 changed the base branch from main to 06-20-Refactoring_install_method_splitting_into_a_helper_function June 20, 2024 21:36
This was referenced Jun 20, 2024
Merged
Closed
Merged
@rohinb2 rohinb2 force-pushed the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch from 0495161 to 7c7befc Compare June 21, 2024 19:36
@rohinb2 rohinb2 marked this pull request as ready for review June 21, 2024 20:32
@rohinb2 rohinb2 force-pushed the 06-20-Refactoring_install_method_splitting_into_a_helper_function branch from ee8d3e2 to f075387 Compare June 24, 2024 00:51
@rohinb2 rohinb2 force-pushed the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch from 7c7befc to 3f27e5e Compare June 24, 2024 00:51
This was referenced Jun 24, 2024
Merged
Merged
@rohinb2 rohinb2 force-pushed the 06-20-Refactoring_install_method_splitting_into_a_helper_function branch from f075387 to 76ee237 Compare June 24, 2024 02:20
@rohinb2 rohinb2 force-pushed the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch from 3f27e5e to cf4d086 Compare June 24, 2024 02:20
@rohinb2 rohinb2 force-pushed the 06-20-Refactoring_install_method_splitting_into_a_helper_function branch from 76ee237 to e66a749 Compare June 25, 2024 14:17
@rohinb2 rohinb2 force-pushed the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch from cf4d086 to 5609234 Compare June 25, 2024 14:18
@rohinb2 rohinb2 mentioned this pull request Jun 25, 2024
Merged
dongreenberg
dongreenberg reviewed Jun 25, 2024
View reviewed changes
runhouse/resources/functions/function_factory.py
fn_pointers = Function._extract_pointers(fn, reqs=env.reqs)
fn_pointers, req_to_add = Function._extract_pointers(fn, reqs=env.reqs)
if req_to_add:
env.reqs = [req_to_add] + env.reqs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check if it's already present?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do we return None if it's already present?

@rohinb2 rohinb2 mentioned this pull request Jun 25, 2024
Merged
@rohinb2 Graphite App
Copy link
Contributor Author

rohinb2 commented Jun 25, 2024 •
edited
Loading

Merge activity

  • Jun 25, 3:28 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Jun 25, 3:31 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 25, 3:32 PM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 force-pushed the 06-20-Refactoring_install_method_splitting_into_a_helper_function branch from e66a749 to f16dbac Compare June 25, 2024 19:29
Base automatically changed from 06-20-Refactoring_install_method_splitting_into_a_helper_function to main June 25, 2024 19:30
@rohinb2 rohinb2 force-pushed the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch from 5609234 to 08401c0 Compare June 25, 2024 19:31
@rohinb2 rohinb2 merged commit 5bde4a9 into main Jun 25, 2024
13 checks passed
@rohinb2 rohinb2 deleted the 06-18-Add_module_pointers_to_env_if_they_don_t_exist branch June 25, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongreenberg dongreenberg dongreenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohinb2 @dongreenberg