Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency: haskell-backend/src/main/native/haskell-backend #3059

Merged
merged 18 commits into from
Dec 2, 2022

Conversation

rv-jenkins
Copy link
Contributor

No description provided.

ana-pantilie
ana-pantilie previously approved these changes Nov 29, 2022
@ehildenb
Copy link
Member

With this patch:

commit 51a5505a1d7c811aaa413611faa9d08009c6d344 (_update-deps_runtimeverification_haskell-backend)
Author: Everett Hildenbrandt <everett.hildenbrandt@gmail.com>
Date:   Wed Nov 30 20:33:50 2022 +0000

    set-symbolic-tests/inset-11-spec.k: update expected output

diff --git a/k-distribution/tests/regression-new/set-symbolic-tests/inset-11-spec.k.out b/k-distribution/tests/regression-new/set-symbolic-tests/inset-11-spec.k.out
index 1d23c8966c..2d6852aa97 100644
--- a/k-distribution/tests/regression-new/set-symbolic-tests/inset-11-spec.k.out
+++ b/k-distribution/tests/regression-new/set-symbolic-tests/inset-11-spec.k.out
@@ -3,6 +3,13 @@
     SetItem ( X:MyId )
     SetItem ( Z:MyId ) ) ~> .
   </k>
+#And
+  {
+    false
+  #Equals
+    X:MyId in SET
+    SetItem ( Z:MyId )
+  }
 #And
   {
     false
@@ -16,4 +23,10 @@
     Z:MyId in SET
     SetItem ( X:MyId )
   }
+#And
+  {
+    false
+  #Equals
+    Z:MyId in SET
+  }
 [Error] Prover: backend terminated because the configuration cannot be rewritten further. See output for more details.

Then the tests pass.

In particular, the test looks like this:

// Copyright (c) 2022 K Team. All Rights Reserved.
// generated by gen-tests.sh

requires "set-tests.k"

module INSET-11-SPEC
    imports SET-TESTS

    claim <k> inSet ( Y:MyId in ( SetItem(Z:MyId) SET:Set SetItem(X:MyId) ) ) => . </k>

endmodule

And the original output looks like this:

  <k>
    inSetResult ( Y:MyId in SET
    SetItem ( X:MyId )
    SetItem ( Z:MyId ) ) ~> .
  </k>
#And
  { 
    false
  #Equals
    X:MyId in SET
  }
#And
  {
    false
  #Equals
    Z:MyId in SET
    SetItem ( X:MyId )
  }
[Error] Prover: backend terminated because the configuration cannot be rewritten further. See output for more details.

But the new output looks like this:

  <k>
    inSetResult ( Y:MyId in SET
    SetItem ( X:MyId )
    SetItem ( Z:MyId ) ) ~> .
  </k>
#And
  { 
    false
  #Equals
    X:MyId in SET
    SetItem ( Z:MyId ) 
  }
#And
  {
    false
  #Equals
    X:MyId in SET 
  } 
#And 
  { 
    false 
  #Equals 
    Z:MyId in SET
    SetItem ( X:MyId )
  } 
#And 
  { 
    false 
  #Equals 
    Z:MyId in SET 
  }
[Error] Prover: backend terminated because the configuration cannot be rewritten further. See output for more details.

So, it's added the extra conditions { false #Equals X in SET SetItem(Z) } and { false #Equals Z in SET } are added. These are both valid conditions triggered by assuming #Ceil of the LHS of the proof obligation, but I'm wondering why we didn't have them before?

@ehildenb ehildenb dismissed ana-pantilie’s stale review November 30, 2022 20:40

We need to find out why the change in test output is needed.

…7956 - Clean up some Template Haskell quoting (#3371)
…d6fa - Minor cleanups in Kore.Unification.NewUnifier (#3367)
…f2ce - Remove some redundant instance constraints (#3370)
…3f33 - Kore Server: fix substitution result sort (#3386)
…fa4b - Print build logs when building Nix flakes (#3389)
@ehildenb ehildenb force-pushed the _update-deps_runtimeverification_haskell-backend branch from f557e8e to c898011 Compare November 30, 2022 20:45
@ehildenb
Copy link
Member

The first commit in the backend which causes this change is this one: runtimeverification/haskell-backend#3338

@rv-jenkins rv-jenkins merged commit 1ae9430 into develop Dec 2, 2022
@rv-jenkins rv-jenkins deleted the _update-deps_runtimeverification_haskell-backend branch December 2, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants