Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix can't find mvn #3366

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Fix can't find mvn #3366

merged 2 commits into from
Apr 26, 2023

Conversation

radumereuta
Copy link
Contributor

@radumereuta radumereuta commented Apr 26, 2023

I'm hoping this is why it can't find mvn.

Right now the jammy deploy fails with

+ docker exec -t k-package-docker-test-jammy-5dde91161befd1f004ba0af7b8527e0616ae799c bash -c 'mv /tmp/settings.xml ~/.m2/settings.xml'
+ docker exec k-package-docker-test-jammy-5dde91161befd1f004ba0af7b8527e0616ae799c /bin/bash -c 'mvn --batch-mode deploy'
/bin/bash: line 1: mvn: command not found
Error: Process completed with exit code 127.

@radumereuta radumereuta requested a review from a team as a code owner April 26, 2023 14:05
@ehildenb
Copy link
Member

This change seems nice for uniformity, but I don't think it will fix the issue. I don't see maven listed in the Docker image we're using here for testing:

&& apt-get install --yes \
, or in the runtime dependencies of K framework package:
Depends: bison , clang-14 , default-jre-headless , flex , gcc , g++ , libboost-dev , libffi-dev , libfmt-dev , libgmp-dev , libjemalloc-dev , libmpfr-dev , libtinfo-dev , libyaml-0-2 , libz3-4 , lld-14 , llvm-14 , pkg-config

I don't think we really want to put it in either of those places, because we want to test that the package works without having the build system present. So really, we should be doing the deployment of the java artifacts from a different docker container, probably from the docker container that is used for main testing: https://github.com/runtimeverification/k/blob/master/.github/workflows/Dockerfile

I would suggest:

  • Pull out the mvn deploy into it's own job, instead of mixing it into the Dockerhub image build job.
  • Have that use the with-docker action, which you can see examples of using that in other places in the repo, and that will use the linked Dockerfile at .github/workflows/Dockerfile, which does have maven installed.

@rv-jenkins rv-jenkins merged commit 28a7577 into develop Apr 26, 2023
@rv-jenkins rv-jenkins deleted the fixCantFindMvn branch April 26, 2023 16:43
ehildenb added a commit that referenced this pull request Apr 26, 2023
dwightguth pushed a commit that referenced this pull request Apr 27, 2023
* Revert "Fix can't find mvn (#3366)"

This reverts commit 28a7577.

* Revert "Working around for cp unable to resolve incontainer tilden expession (#3362)"

This reverts commit d9e4b92.

* Revert "Fixing missing directory in temp container for m2 settings.xml (#3351)"

This reverts commit c744ade.

* Revert "Pt.1 change to push location for mvn packages (#3338)"

This reverts commit cf26966.
Baltoli pushed a commit that referenced this pull request Nov 1, 2023
…3059)

* !!! (31415a0b) haskell-backend/src/main/native/haskell-backend: 31415a0b6 - Remove AcceptsMultipleResults (#3366)

* !!! (9a0e2c29) haskell-backend/src/main/native/haskell-backend: 9a0e2c299 - Update dependency: deps/k_release (#3361)

* !!! (ac889cea) haskell-backend/src/main/native/haskell-backend: ac889cea8 - Monomorphization of Simplifier, leg #2 (#3346)

* !!! (e4bf0795) haskell-backend/src/main/native/haskell-backend: e4bf07956 - Clean up some Template Haskell quoting (#3371)

* !!! (40ec7d6f) haskell-backend/src/main/native/haskell-backend: 40ec7d6fa - Minor cleanups in Kore.Unification.NewUnifier (#3367)

* !!! (9b8df510) haskell-backend/src/main/native/haskell-backend: 9b8df510b - Df/caching termlike hashes (#3338)

* !!! (5623b560) haskell-backend/src/main/native/haskell-backend: 5623b5603 - Monomorphization of Simplifier, leg #3 (#3375)

* !!! (4e76bf2c) haskell-backend/src/main/native/haskell-backend: 4e76bf2ce - Remove some redundant instance constraints (#3370)

* !!! (0d66d723) haskell-backend/src/main/native/haskell-backend: 0d66d7239 - Update dependency: deps/k_release (#3368)

* !!! (9491e547) haskell-backend/src/main/native/haskell-backend: 9491e547a - Use source location in rewrite trace (#3382)

* !!! (0bb5f8b3) haskell-backend/src/main/native/haskell-backend: 0bb5f8b31 - Update dependency: deps/k_release (#3385)

* !!! (154ac3f3) haskell-backend/src/main/native/haskell-backend: 154ac3f33 - Kore Server: fix substitution result sort (#3386)

* !!! (bdfc0fa4) haskell-backend/src/main/native/haskell-backend: bdfc0fa4b - Print build logs when building Nix flakes (#3389)

* Sync flake inputs to submodules

* set-symbolic-tests/inset-11-spec: update expected output

* Sync flake inputs to submodules

* Sync flake inputs to submodules

Co-authored-by: Everett Hildenbrandt <everett.hildenbrandt@gmail.com>
Co-authored-by: rv-jenkins <devops@runtimeverification.com>
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants