Pt.1 change to push location for mvn packages #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onManagement repository on release builds, defaults to do not upload anything
…o action 'token', to provide secret WHEN deploying only
ehildenb
reviewed
Apr 14, 2023
…packaging, and MacOS Packaging
|
An error in using submodules; recursive in actions/checkout@v3 fails here A simple workaround is to run the explicit git command. |
dwightguth
reviewed
Apr 17, 2023
There was a problem hiding this comment.
Why are there two different calls to mvn deploy in this workflow? As far as I can tell, one is Linux and the other is MacOS, but I don't believe maven actually deploys anything that is platform-specific, so you ought to need to do it only once during the actual final creation of the release.
Removing redundant mvn publish
Set batch mode
|
Updated to remove mvn push in Mac build steps |
ehildenb
reviewed
Apr 19, 2023
| @@ -106,6 +118,9 @@ jobs: | |||
| docker exec -t k-package-docker-test-jammy-${GITHUB_SHA} bash -c 'cd ~ && kompile test.k --backend llvm' | |||
| docker exec -t k-package-docker-test-jammy-${GITHUB_SHA} bash -c 'cd ~ && kompile test.k --backend haskell' | |||
| docker image push ${DOCKERHUB_REPO}:${version_tag} | |||
| docker cp ~/.m2/settings.xml k-package-docker-test-jammy-${GITHUB_SHA}:~/.m2/settings.xml | |||
There was a problem hiding this comment.
I don't understand tihs docker cp ... command? Are we copying a file from the host into the docker image? Why? Shouldn't everything happen inside the docker container?
There was a problem hiding this comment.
Even more confusing, why is this coming from the host machines home directory, rather than some specific file in teh K repo?
There was a problem hiding this comment.
This file contains secrets like the maven username and password, so it gets initialized by the CI and it's getting copied into the docker image where it's being used.
dwightguth
approved these changes
Apr 19, 2023
dwightguth
pushed a commit
that referenced
this pull request
Apr 27, 2023
* Revert "Fix can't find mvn (#3366)" This reverts commit 28a7577. * Revert "Working around for cp unable to resolve incontainer tilden expession (#3362)" This reverts commit d9e4b92. * Revert "Fixing missing directory in temp container for m2 settings.xml (#3351)" This reverts commit c744ade. * Revert "Pt.1 change to push location for mvn packages (#3338)" This reverts commit cf26966.
Baltoli
pushed a commit
that referenced
this pull request
Nov 1, 2023
…3059) * !!! (31415a0b) haskell-backend/src/main/native/haskell-backend: 31415a0b6 - Remove AcceptsMultipleResults (#3366) * !!! (9a0e2c29) haskell-backend/src/main/native/haskell-backend: 9a0e2c299 - Update dependency: deps/k_release (#3361) * !!! (ac889cea) haskell-backend/src/main/native/haskell-backend: ac889cea8 - Monomorphization of Simplifier, leg #2 (#3346) * !!! (e4bf0795) haskell-backend/src/main/native/haskell-backend: e4bf07956 - Clean up some Template Haskell quoting (#3371) * !!! (40ec7d6f) haskell-backend/src/main/native/haskell-backend: 40ec7d6fa - Minor cleanups in Kore.Unification.NewUnifier (#3367) * !!! (9b8df510) haskell-backend/src/main/native/haskell-backend: 9b8df510b - Df/caching termlike hashes (#3338) * !!! (5623b560) haskell-backend/src/main/native/haskell-backend: 5623b5603 - Monomorphization of Simplifier, leg #3 (#3375) * !!! (4e76bf2c) haskell-backend/src/main/native/haskell-backend: 4e76bf2ce - Remove some redundant instance constraints (#3370) * !!! (0d66d723) haskell-backend/src/main/native/haskell-backend: 0d66d7239 - Update dependency: deps/k_release (#3368) * !!! (9491e547) haskell-backend/src/main/native/haskell-backend: 9491e547a - Use source location in rewrite trace (#3382) * !!! (0bb5f8b3) haskell-backend/src/main/native/haskell-backend: 0bb5f8b31 - Update dependency: deps/k_release (#3385) * !!! (154ac3f3) haskell-backend/src/main/native/haskell-backend: 154ac3f33 - Kore Server: fix substitution result sort (#3386) * !!! (bdfc0fa4) haskell-backend/src/main/native/haskell-backend: bdfc0fa4b - Print build logs when building Nix flakes (#3389) * Sync flake inputs to submodules * set-symbolic-tests/inset-11-spec: update expected output * Sync flake inputs to submodules * Sync flake inputs to submodules Co-authored-by: Everett Hildenbrandt <everett.hildenbrandt@gmail.com> Co-authored-by: rv-jenkins <devops@runtimeverification.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 to update distributionManagement in Pom for first release.