Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch smoke test. #9921

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Add fetch smoke test. #9921

merged 1 commit into from
Sep 22, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 19, 2021

This adds a test with a statically built curl to check if running cargo fetch works. This adds a few minutes to CI time, but I think it is worthwhile to try to catch some regressions.

Note that macOS uses system curl to match the rust-lang/rust build mode.

@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 20, 2021

📌 Commit 90b2ef0 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2021
@bors
Copy link
Contributor

bors commented Sep 20, 2021

⌛ Testing commit 90b2ef0 with merge b617e7742b6b8be1c9f84591e80c8521d293f8a5...

@bors
Copy link
Contributor

bors commented Sep 20, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2021
@alexcrichton
Copy link
Member

Well the good news is that this works. The bad news is it can't land. I could yank the most recent version of curl-sys on crates.io (or publish a new one with a downgraded submodule). Alternatively it looks like a patched version of curl will come out in a few days so we can also wait until then, so I think I'd prefer to do that.

@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2021
@bors
Copy link
Contributor

bors commented Sep 22, 2021

⌛ Testing commit 90b2ef0 with merge 7914554...

@bors
Copy link
Contributor

bors commented Sep 22, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 7914554 to master...

@bors bors merged commit 7914554 into rust-lang:master Sep 22, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2021
Update cargo

7 commits in 9a28ac83c9eb73e42ffafac552c0a55f00dbf40c..0121d66aa2ef5ffa9735f86c2b56f5fdc5a837a6
2021-09-18 15:42:28 -0500 to 2021-09-22 16:08:27 +0000
- Implement example completion for zsh (rust-lang/cargo#9939)
- Bump curl-sys dependency (rust-lang/cargo#9937)
- Add fetch smoke test. (rust-lang/cargo#9921)
- Differentiate tests in progress bar. (rust-lang/cargo#9934)
- Remove TOML incompatibility hacks (rust-lang/cargo#9932)
- Change diesel compatibility messages (rust-lang/cargo#9927)
- Remove broken link in contrib docs. (rust-lang/cargo#9928)
@ehuss ehuss added this to the 1.57.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants