Remove TOML incompatibility hacks #9932
Conversation
- `set_require_newline_after_table` was added in rust-lang#2680 back in 2016 - `set_allow_duplicate_after_longer_table` was added in rust-lang#6761 in 2019 Several years later, this PR is turning these warnings into errors. The function and documentation was kept so we can add additional hacks in the future, like if we switch TOML parsers.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ For anyone watching this we recently applied a similar change where a very-old warning became an error. This caused issues and was later reverted with the conclusion that we wouldn't back things out unless transitive dependencies have been warning for some time. The backcompat things removed in this commit are not in the same category, though, because it appears that these warnings go straight to the shell rather than to only the manifest's own warnings. This means that everyone should have been seeing these warnings for quite some time if they were affected by anything in their dependency graph. This I believe means that unlike #9686 this should be safe to land. |
|
📌 Commit 2fdb710 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 7 commits in 9a28ac83c9eb73e42ffafac552c0a55f00dbf40c..0121d66aa2ef5ffa9735f86c2b56f5fdc5a837a6 2021-09-18 15:42:28 -0500 to 2021-09-22 16:08:27 +0000 - Implement example completion for zsh (rust-lang/cargo#9939) - Bump curl-sys dependency (rust-lang/cargo#9937) - Add fetch smoke test. (rust-lang/cargo#9921) - Differentiate tests in progress bar. (rust-lang/cargo#9934) - Remove TOML incompatibility hacks (rust-lang/cargo#9932) - Change diesel compatibility messages (rust-lang/cargo#9927) - Remove broken link in contrib docs. (rust-lang/cargo#9928)
`toml_edit` won't be able to support these. For example, cargo moved away from these in rust-lang/cargo#9932 to prepare for rust-lang/cargo#10086
`toml_edit` won't be able to support these. For example, cargo moved away from these in rust-lang/cargo#9932 to prepare for rust-lang/cargo#10086 This is prep for toml-rs#340
`toml_edit` won't be able to support these. For example, cargo moved away from these in rust-lang/cargo#9932 to prepare for rust-lang/cargo#10086 This is prep for toml-rs#340
set_require_newline_after_tablewas added in Update TOML parser to pick up a bugfix #2680 back in 2016set_allow_duplicate_after_longer_tablewas added in Handle backcompat hazard withtomlcrate #6761 in 2019Several years later, this PR is turning these warnings into errors.
The function and documentation was kept so we can add additional hacks
in the future, like if we switch TOML parsers.