Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate tests in progress bar. #9934

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 22, 2021

Some people have expressed confusion when the progress bar includes the package name twice, such as:

Building [=======================> ] 301/307: rustc_interface, rustc_interface

This can happen in a variety of circumstances, but a common one is cargo test. This causes the library to be built in parallel with the library being built for unittests. This PR adds some additional markers to differentiate what is being built:

  • Lib as test: lib_name(test)
  • Binary as test: bin_name(bin test)
  • Example as test: example_name(example test)

@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Sep 22, 2021

📌 Commit 4e9302e has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2021
@bors
Copy link
Collaborator

bors commented Sep 22, 2021

⌛ Testing commit 4e9302e with merge f36ee65...

@bors
Copy link
Collaborator

bors commented Sep 22, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing f36ee65 to master...

@bors bors merged commit f36ee65 into rust-lang:master Sep 22, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2021
Update cargo

7 commits in 9a28ac83c9eb73e42ffafac552c0a55f00dbf40c..0121d66aa2ef5ffa9735f86c2b56f5fdc5a837a6
2021-09-18 15:42:28 -0500 to 2021-09-22 16:08:27 +0000
- Implement example completion for zsh (rust-lang/cargo#9939)
- Bump curl-sys dependency (rust-lang/cargo#9937)
- Add fetch smoke test. (rust-lang/cargo#9921)
- Differentiate tests in progress bar. (rust-lang/cargo#9934)
- Remove TOML incompatibility hacks (rust-lang/cargo#9932)
- Change diesel compatibility messages (rust-lang/cargo#9927)
- Remove broken link in contrib docs. (rust-lang/cargo#9928)
@ehuss ehuss added this to the 1.57.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants