Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary raw pointer in __rust_start_panic arg #102742

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Remove unnecessary raw pointer in __rust_start_panic arg #102742

merged 1 commit into from
Mar 27, 2023
+10 −15

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Oct 6, 2022

It is no longer necessary as __rust_start_panic switched to the Rust abi.

@bjorn3 bjorn3 added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Oct 6, 2022
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 6, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2022
@bjorn3
Copy link
Member Author

bjorn3 commented Oct 6, 2022

Miri uses miri_start_panic as unwind entrypoint, which is called by panic_unwind's __rust_start_panic, so no miri changes needed afaict.

@Aaron1011
Copy link
Member

For reference, my previous comment was "I think this will require changes to Miri". I deleted it shortly after posting it, as I realized it was incorrect :)

@ChrisDenton
Copy link
Member

This looks like a nice improvement. Maybe squish the commits though?

@bjorn3
Remove unnecessary raw pointer in __rust_start_panic arg
b874502 
It is no longer necessary as __rust_start_panic switched to the Rust abi.
@bjorn3
Copy link
Member Author

bjorn3 commented Mar 26, 2023

Rebased and squashed.

@ChrisDenton
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 26, 2023

📌 Commit b874502 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 26, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2023
@bors
Auto merge of rust-lang#109652 - matthiaskrgr:rollup-pbw3hi3, r=matth…
553ecbe 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#97506 (Stabilize `nonnull_slice_from_raw_parts`)
 - rust-lang#98651 (Follow C-RW-VALUE in std::io::Cursor example)
 - rust-lang#102742 (Remove unnecessary raw pointer in __rust_start_panic arg)
 - rust-lang#109587 (Use an IndexVec to debug fingerprints.)
 - rust-lang#109613 (fix type suggestions in match arms)
 - rust-lang#109633 (Fix "Directly go to item in search if there is only one result" setting)
 - rust-lang#109635 (debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of)
 - rust-lang#109641 (Don't elaborate non-obligations into obligations)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 704991c into rust-lang:master Mar 27, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 27, 2023
@bjorn3 bjorn3 deleted the cleanup_rust_start_panic branch March 27, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@BlackHoleFox BlackHoleFox BlackHoleFox left review comments

Assignees

@joshtriplett joshtriplett

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
9 participants
@bjorn3 @rustbot @rust-highfive @Aaron1011 @ChrisDenton @bors @RalfJung @BlackHoleFox @joshtriplett