Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Directly go to item in search if there is only one result" setting #109633

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

GuillaumeGomez
Copy link
Member

Part of #66181.

The setting was actually broken, so I fixed it when I added the GUI test.

r? @notriddle

@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review March 26, 2023 15:51
@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 26, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 26, 2023

📌 Commit bc9eec0 has been approved by notriddle

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 26, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 27, 2023
…ing, r=notriddle

Fix "Directly go to item in search if there is only one result" setting

Part of rust-lang#66181.

The setting was actually broken, so I fixed it when I added the GUI test.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#97506 (Stabilize `nonnull_slice_from_raw_parts`)
 - rust-lang#98651 (Follow C-RW-VALUE in std::io::Cursor example)
 - rust-lang#102742 (Remove unnecessary raw pointer in __rust_start_panic arg)
 - rust-lang#109587 (Use an IndexVec to debug fingerprints.)
 - rust-lang#109613 (fix type suggestions in match arms)
 - rust-lang#109633 (Fix "Directly go to item in search if there is only one result" setting)
 - rust-lang#109635 (debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of)
 - rust-lang#109641 (Don't elaborate non-obligations into obligations)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b39db70 into rust-lang:master Mar 27, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 27, 2023
@GuillaumeGomez GuillaumeGomez deleted the fix-go-to-only-setting branch March 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants