Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of #109635

Merged
merged 1 commit into from
Mar 27, 2023
Merged

debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of #109635

merged 1 commit into from
Mar 27, 2023

Conversation

Noratrieb
Copy link
Member

This avoids some type interning and a query execution. It also just makes the code simpler.

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2023
@Noratrieb
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 26, 2023
@bors
Copy link
Contributor

bors commented Mar 26, 2023

⌛ Trying commit 3a2b3a9df34a28202ff892d266b5c4a972b624cd with merge 84ff48dc4b9a601fb878348fe8a97a86af4f7fc2...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 26, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2023
@Noratrieb
debuginfo: Get pointer size/align from tcx.data_layout instead of lay…
72c917d 
…out_of

This avoids some type interning and a query execution. It also just
makes the code simpler.
@Noratrieb
Copy link
Member Author

great job nils, that was very good very working code
@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 26, 2023

⌛ Trying commit 72c917d with merge e150b480d5aaa64ade612727a11f6e5a7b21bf36...

compiler-errors
compiler-errors approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if perf comes back clean

@bors
Copy link
Contributor

bors commented Mar 26, 2023

☀️ Try build successful - checks-actions
Build commit: e150b480d5aaa64ade612727a11f6e5a7b21bf36 (e150b480d5aaa64ade612727a11f6e5a7b21bf36)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e150b480d5aaa64ade612727a11f6e5a7b21bf36): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.4% [0.6%, 2.3%] 20
Regressions ❌
(secondary)		 5.1% [5.1%, 5.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.4% [0.6%, 2.3%] 20

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 26, 2023
@Noratrieb
Copy link
Member Author

@bors r=compiler=errors rollup

@bors
Copy link
Contributor

bors commented Mar 27, 2023

📌 Commit 72c917d has been approved by compiler=errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2023
@bors
Auto merge of rust-lang#109652 - matthiaskrgr:rollup-pbw3hi3, r=matth…
553ecbe 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#97506 (Stabilize `nonnull_slice_from_raw_parts`)
 - rust-lang#98651 (Follow C-RW-VALUE in std::io::Cursor example)
 - rust-lang#102742 (Remove unnecessary raw pointer in __rust_start_panic arg)
 - rust-lang#109587 (Use an IndexVec to debug fingerprints.)
 - rust-lang#109613 (fix type suggestions in match arms)
 - rust-lang#109633 (Fix "Directly go to item in search if there is only one result" setting)
 - rust-lang#109635 (debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of)
 - rust-lang#109641 (Don't elaborate non-obligations into obligations)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2b7dc94 into rust-lang:master Mar 27, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 27, 2023
@Noratrieb Noratrieb deleted the debrrruginfo branch March 27, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Noratrieb @rustbot @rust-timer @bors @rust-log-analyzer @compiler-errors @wesleywiser