Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize proc_macro::Span::source_text #103197

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Stabilize proc_macro::Span::source_text #103197

merged 1 commit into from
Oct 20, 2022

Conversation

est31
Copy link
Member

@est31 est31 commented Oct 18, 2022 •
edited
Loading

Splits proc_macro::Span::source_text into a new feature gate and stabilizes it. The FCP is complete.

impl Span {
    pub fn source_text(&self) -> Option<String>;
}

Closes #101991

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022
@est31 est31 mentioned this pull request Oct 18, 2022
Closed
@est31
Stabilize proc_macro::Span::source_text
d89fb1d 
Splits proc_macro::Span::source_text into a new feature gate and stabilizes it.
@est31 est31 force-pushed the stabilize_proc_macro_source_text branch from 89fde40 to d89fb1d Compare October 18, 2022 15:14
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 19, 2022

📌 Commit d89fb1d has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022
@petrochenkov petrochenkov added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 19, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 19, 2022
@Dylan-DPC
Rollup merge of rust-lang#103197 - est31:stabilize_proc_macro_source_…
3d429d8 
…text, r=petrochenkov

Stabilize proc_macro::Span::source_text

Splits `proc_macro::Span::source_text` into a new feature gate and stabilizes it. The [FCP is complete](rust-lang#101991 (comment)).

```Rust
impl Span {
    pub fn source_text(&self) -> Option<String>;
}
```

Closes rust-lang#101991
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 19, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 20, 2022
@bors
Auto merge of rust-lang#103290 - matthiaskrgr:rollup-ngozai3, r=matth…
542febd 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#103197 (Stabilize proc_macro::Span::source_text)
 - rust-lang#103251 (Fix item declaration highlighting)
 - rust-lang#103262 (Adjusting test to needs-unwind, with linking issue)
 - rust-lang#103268 (rustdoc: remove no-op CSS `nav.sub { font-size: 1rem }`)
 - rust-lang#103272 (Remove extra spaces in docs)
 - rust-lang#103276 (Erase regions before checking for `Default` in uninitialized binding error)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62bb0c6 into rust-lang:master Oct 20, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

Stabilize proc_macro Span::source_text
5 participants
@est31 @rustbot @rust-highfive @petrochenkov @bors