Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #103290

Merged
merged 13 commits into from
Oct 20, 2022
Merged

Rollup of 6 pull requests #103290

merged 13 commits into from
Oct 20, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

est31 and others added 13 commits October 18, 2022 17:13
Splits proc_macro::Span::source_text into a new feature gate and stabilizes it.
This rule originated as a `font-size: 16px`, when body had `font-size: 13px`
set in 4fd061c.

It remained even when body's font size was bumped up to 16px,
4d5f4ff, making the rule a no-op, and was
carried forward when it was converted to 1rem in
cc18120.
…text, r=petrochenkov

Stabilize proc_macro::Span::source_text

Splits `proc_macro::Span::source_text` into a new feature gate and stabilizes it. The [FCP is complete](rust-lang#101991 (comment)).

```Rust
impl Span {
    pub fn source_text(&self) -> Option<String>;
}
```

Closes rust-lang#101991
…ing, r=notriddle

Fix item declaration highlighting

Fixes rust-lang#103050.

As mentioned in the issue, rust-lang#102924 introduced this regression. This PR partially reverts it and adds a regression test.

r? `@notriddle`
… r=tmandry

Adjusting test to needs-unwind, with linking issue

Test requires `needs-unwind` (see linked issue rust-lang#103261)
…ize, r=GuillaumeGomez

rustdoc: remove no-op CSS `nav.sub { font-size: 1rem }`

This rule originated as a `font-size: 16px`, when body had `font-size: 13px` set in 4fd061c.

It remained even when body's font size was bumped up to 16px, 4d5f4ff, making the rule a no-op, and was carried forward when it was converted to 1rem in cc18120.
Remove extra spaces in docs

Removing some random extra spaces in the examples for `core::sync::atomic`.

r? `@thomcc`
…ice, r=TaKO8Ki

Erase regions before checking for `Default` in uninitialized binding error

Fixes rust-lang#103250
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 20, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Oct 20, 2022

📌 Commit e29ecb7 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 20, 2022
@bors
Copy link
Contributor

bors commented Oct 20, 2022

⌛ Testing commit e29ecb7 with merge a69f5b85a04a214b5ec236efd1710f99363d9db5...

@bors
Copy link
Contributor

bors commented Oct 20, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 20, 2022
@matthiaskrgr
Copy link
Member Author

@bors retry crates.io timeout

Downloading crates ...
warning: spurious network error (2 tries remaining): [28] Timeout was reached (download of camino v1.0.9 failed to transfer more than 10 bytes in 30s)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2022
@rust-log-analyzer
Copy link
Collaborator

The job dist-aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Oct 20, 2022

⌛ Testing commit e29ecb7 with merge 542febd...

@bors
Copy link
Contributor

bors commented Oct 20, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 542febd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 20, 2022
@bors bors merged commit 542febd into rust-lang:master Oct 20, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 20, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#103276 6894d477cec4b18255c66f73cf9baf2b2cdda74b
#103272 1fe94c0028db70eb98110736ae12473af56f842a
#103268 378841f2652fc55bfb8ba461c334880f509ee7ec
#103262 ac4d4249bfcb1e46052a1fac5f3c9da0061c3a9e
#103251 9d0882ebf80a2c631358305879ec6d5075d3b385
#103197 a4f2058eac5b2525246ca125467fc751b8cedadf

previous master: 53728ff751

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (542febd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@matthiaskrgr matthiaskrgr deleted the rollup-ngozai3 branch December 22, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.