Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove no-op CSS nav.sub { font-size: 1rem } #103268

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

notriddle
Copy link
Contributor

This rule originated as a font-size: 16px, when body had font-size: 13px set in 4fd061c.

It remained even when body's font size was bumped up to 16px, 4d5f4ff, making the rule a no-op, and was carried forward when it was converted to 1rem in cc18120.

This rule originated as a `font-size: 16px`, when body had `font-size: 13px`
set in 4fd061c.

It remained even when body's font size was bumped up to 16px,
4d5f4ff, making the rule a no-op, and was
carried forward when it was converted to 1rem in
cc18120.
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 19, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 19, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2022
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 19, 2022

📌 Commit 0dd329f has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 20, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#103197 (Stabilize proc_macro::Span::source_text)
 - rust-lang#103251 (Fix item declaration highlighting)
 - rust-lang#103262 (Adjusting test to needs-unwind, with linking issue)
 - rust-lang#103268 (rustdoc: remove no-op CSS `nav.sub { font-size: 1rem }`)
 - rust-lang#103272 (Remove extra spaces in docs)
 - rust-lang#103276 (Erase regions before checking for `Default` in uninitialized binding error)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f8dfddb into rust-lang:master Oct 20, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 20, 2022
@notriddle notriddle deleted the notriddle/nav-sub-font-size branch October 20, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants