-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #103597
Rollup of 11 pull requests #103597
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f310d4c - Browse repository at this point
Copy the full SHA f310d4cView commit details
Commits on Oct 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d7fb8d5 - Browse repository at this point
Copy the full SHA d7fb8d5View commit details
Commits on Oct 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d5f467a - Browse repository at this point
Copy the full SHA d5f467aView commit details
Commits on Oct 17, 2022
-
Auto merge of rust-lang#13399 - DropDemBits:assists-format-args-captu…
…re-pt2, r=Veykril Migrate assists to format args captures, part 2 Continuation of rust-lang#13379 Migrates: - `generate_constant` - `generate_default_from_enum_variant` - `generate_default_from_new` - `generate_delegate_methods` - `generate_deref` - `generate_documentation_template` - `generate_enum_is_method` - `generate_enum_projection_method` - `generate_from_impl_for_enum` - `generate_function` - `generate_getter` - `generate_impl` - `generate_new` - `generate_setter`
Configuration menu - View commit details
-
Copy full SHA for a2e4f78 - Browse repository at this point
Copy the full SHA a2e4f78View commit details -
Auto merge of rust-lang#13423 - Veykril:vscode-vars, r=Veykril
Substitute some VSCode variables in the VSCode client cc rust-lang/rust-analyzer#13405
Configuration menu - View commit details
-
Copy full SHA for 40cbeb5 - Browse repository at this point
Copy the full SHA 40cbeb5View commit details -
Auto merge of rust-lang#13302 - Veykril:auto-publish, r=Veykril
Don't auto-publish lib crates I believe this should *just* work? With this cargo-workspaces should not consider them
Configuration menu - View commit details
-
Copy full SHA for f079792 - Browse repository at this point
Copy the full SHA f079792View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f43597 - Browse repository at this point
Copy the full SHA 6f43597View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aaafdd - Browse repository at this point
Copy the full SHA 8aaafddView commit details -
Configuration menu - View commit details
-
Copy full SHA for d68616a - Browse repository at this point
Copy the full SHA d68616aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0421756 - Browse repository at this point
Copy the full SHA 0421756View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b5c943 - Browse repository at this point
Copy the full SHA 7b5c943View commit details -
Configuration menu - View commit details
-
Copy full SHA for d63c44e - Browse repository at this point
Copy the full SHA d63c44eView commit details -
Auto merge of rust-lang#13426 - Veykril:client-refactor, r=Veykril
Refactor language client handling Follow up to rust-lang/rust-analyzer#12847 (turns out they fixed parts of the problem) The PR will attempt to allow us to dispose more resources at will, so that we can implement restarts for the server properly instead of restating the entire extension as well as allowing us to implement a stop command. Closes rust-lang/rust-analyzer#12936 Closes rust-lang/rust-analyzer#4697
Configuration menu - View commit details
-
Copy full SHA for 067c410 - Browse repository at this point
Copy the full SHA 067c410View commit details -
Configuration menu - View commit details
-
Copy full SHA for e41023c - Browse repository at this point
Copy the full SHA e41023cView commit details -
Auto merge of rust-lang#13427 - Veykril:cancel-check, r=Veykril
feat: Make flycheck workdone progress reports cancellable In clients that support this (like VSCode), the clients will now render a cancel button on the notification message which can be clicked to cancel the flycheck instead. Closes rust-lang/rust-analyzer#6895 ![Code_VbXgP3SbFD](https://user-images.githubusercontent.com/3757771/196205329-2df93451-c143-4d1b-a700-d988edf55efa.gif)
Configuration menu - View commit details
-
Copy full SHA for 106285b - Browse repository at this point
Copy the full SHA 106285bView commit details -
fix: Fix formatting requests hanging when r-a is still starting
The reason for that was that we were calculating the crate defmaps of the file we are saving by accident causing us to get stuck waiting on their expensive computation, while we only need the relevant crate id.
Configuration menu - View commit details
-
Copy full SHA for a762bac - Browse repository at this point
Copy the full SHA a762bacView commit details -
Auto merge of rust-lang#13428 - Veykril:fmt-stuck, r=Veykril
fix: Fix formatting requests hanging when r-a is still starting The reason for that was that we were calculating the crate defmaps of the file we are saving by accident causing us to get stuck waiting on their expensive computation, while we only need the relevant crate id. Closes rust-lang/rust-analyzer#4054 Closes rust-lang/rust-analyzer#11654
Configuration menu - View commit details
-
Copy full SHA for 4d4c05d - Browse repository at this point
Copy the full SHA 4d4c05dView commit details
Commits on Oct 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8047512 - Browse repository at this point
Copy the full SHA 8047512View commit details -
Auto merge of rust-lang#13433 - rust-lang:revert-13354-try-stuff, r=V…
…eykril Revert "feat: Diagnose some incorrect usages of the question mark operator" Reverts rust-lang/rust-analyzer#13354 It seems like we are getting stuck with inference variables here, not just placeholders and errors so there is probably more wrong here that I don't understand. Reverting seems like the best solution right now as I don't have the time to look into this this week.
Configuration menu - View commit details
-
Copy full SHA for 97b357e - Browse repository at this point
Copy the full SHA 97b357eView commit details
Commits on Oct 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9d3e616 - Browse repository at this point
Copy the full SHA 9d3e616View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3392573 - Browse repository at this point
Copy the full SHA 3392573View commit details -
Configuration menu - View commit details
-
Copy full SHA for 653dafa - Browse repository at this point
Copy the full SHA 653dafaView commit details -
Auto merge of rust-lang#13441 - Veykril:sysroot-logging, r=Veykril
Add some sysroot logging
Configuration menu - View commit details
-
Copy full SHA for 82ac6f7 - Browse repository at this point
Copy the full SHA 82ac6f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e2c41d - Browse repository at this point
Copy the full SHA 7e2c41dView commit details -
Implement invocation strategy config for checkOnSave
Note that due to how cargo works, none of the modes currently work for r-a
Configuration menu - View commit details
-
Copy full SHA for 4a287d2 - Browse repository at this point
Copy the full SHA 4a287d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5174b65 - Browse repository at this point
Copy the full SHA 5174b65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7db5029 - Browse repository at this point
Copy the full SHA 7db5029View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4673236 - Browse repository at this point
Copy the full SHA 4673236View commit details -
Auto merge of rust-lang#13128 - Veykril:invocation-strategy, r=Veykril
Implement invocation strategy config Fixes rust-lang/rust-analyzer#10793 This allows to change how we run build scripts (and `checkOnSave`), exposing two configs: - `once`: run the specified command once in the project root (the working dir of the server) - `per_workspace`: run the specified command per workspace in the corresponding workspace This also applies to `checkOnSave` likewise, though `once_in_root` is useless there currently, due to rust-lang/cargo#11007
Configuration menu - View commit details
-
Copy full SHA for a77ac93 - Browse repository at this point
Copy the full SHA a77ac93View commit details
Commits on Oct 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 69b8456 - Browse repository at this point
Copy the full SHA 69b8456View commit details -
Auto merge of rust-lang#13444 - Veykril:rethrow-err, r=Veykril
fix: Don't catch the server activation error We are are rethrowing and showing errors higher up in the call stack already. This just ate the error hiding the stacktrace unnecessarily.
Configuration menu - View commit details
-
Copy full SHA for 32614e2 - Browse repository at this point
Copy the full SHA 32614e2View commit details -
feat: add multiple getters mode in
generate_getter
This commit adds two modes to generate_getter action. First, the plain old working on single fields. Second, working on a selected range of fields.
Configuration menu - View commit details
-
Copy full SHA for 5bff6c5 - Browse repository at this point
Copy the full SHA 5bff6c5View commit details -
Auto merge of rust-lang#13365 - feniljain:master, r=Veykril
feat: add multiple getters mode in `generate_getter` This commit adds two modes to generate_getter action. First, the plain old working on single fields. Second, working on a selected range of fields. Should partially solve rust-lang#13246 If this gets approved will create a separate PR for setters version of the same ### Points to help in review: - `generate_getter_from_record_info` contains code which is mostly taken from assist before refactor - Same goes for `parse_record_fields` - There are changes in other assists, as one of the methods in utils named `find_struct_impl` is changed, before it used to accept a single `fn_name`, now it takes a list of function names to check against. All old impls are updated to create a small list to pass their single element. ### Assumptions: - If any of the fields have an implementation, the action will quit.
Configuration menu - View commit details
-
Copy full SHA for f3cce5f - Browse repository at this point
Copy the full SHA f3cce5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for de195ff - Browse repository at this point
Copy the full SHA de195ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for e05df93 - Browse repository at this point
Copy the full SHA e05df93View commit details -
Auto merge of rust-lang#13448 - yotamofek:python-ext-polyfill-workaro…
…und, r=Veykril Workaround the python vscode extension's polyfill Fixes rust-lang#13442 `String.replaceAll` and `String.replace` behave the same when given a (/g-flagged) Regex, so fix is very simple.
Configuration menu - View commit details
-
Copy full SHA for 7741e3d - Browse repository at this point
Copy the full SHA 7741e3dView commit details -
Auto merge of rust-lang#13447 - Veykril:didsavedoc-block, r=Veykril
fix: Fix DidSaveDocument requests blocking the server on startup Follow up to rust-lang/rust-analyzer#13428 Fixes rust-lang/rust-analyzer#13434
Configuration menu - View commit details
-
Copy full SHA for 2481721 - Browse repository at this point
Copy the full SHA 2481721View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8e0a20 - Browse repository at this point
Copy the full SHA a8e0a20View commit details -
Auto merge of rust-lang#13451 - Veykril:lang-config, r=Veykril
internal: Properly handle language configuration config changes
Configuration menu - View commit details
-
Copy full SHA for 69f01fd - Browse repository at this point
Copy the full SHA 69f01fdView commit details
Commits on Oct 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1cb4607 - Browse repository at this point
Copy the full SHA 1cb4607View commit details -
Auto merge of rust-lang#13453 - Veykril:disabled-commands, r=Veykril
internal: Properly handle commands in the VSCode client when the server is stopped
Configuration menu - View commit details
-
Copy full SHA for 8ee23f4 - Browse repository at this point
Copy the full SHA 8ee23f4View commit details
Commits on Oct 22, 2022
-
Avoids a couple redundant hash map lookups and so.
Configuration menu - View commit details
-
Copy full SHA for 7ee7225 - Browse repository at this point
Copy the full SHA 7ee7225View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd49d01 - Browse repository at this point
Copy the full SHA bd49d01View commit details -
scip: Rewrite tests to be closer to what we actually do.
It's also less code.
Configuration menu - View commit details
-
Copy full SHA for ec6d72b - Browse repository at this point
Copy the full SHA ec6d72bView commit details -
Auto merge of rust-lang#13461 - emilio:ide-cleanup-continue, r=Veykril
ide: Remove unnecessary continue. Just a minor clean-up I found while going through the code.
Configuration menu - View commit details
-
Copy full SHA for b643dd6 - Browse repository at this point
Copy the full SHA b643dd6View commit details -
Auto merge of rust-lang#13460 - emilio:scip-cleanups, r=Veykril
scip: minor clean-ups Avoids a couple redundant hash map lookups and so.
Configuration menu - View commit details
-
Copy full SHA for d3b7e94 - Browse repository at this point
Copy the full SHA d3b7e94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6459d7f - Browse repository at this point
Copy the full SHA 6459d7fView commit details -
Auto merge of rust-lang#13463 - lowr:fix/builtin-derive-with-const-ge…
…nerics, r=Veykril Support const generics for builtin derive macro Fixes rust-lang#13121 We have been treating every generic parameter as type parameter during builtin derive macro expansion. This patch adds support for const generics in such expansions.
Configuration menu - View commit details
-
Copy full SHA for 19efa0b - Browse repository at this point
Copy the full SHA 19efa0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f8904e - Browse repository at this point
Copy the full SHA 0f8904eView commit details -
Auto merge of rust-lang#13466 - Veykril:invocation-location, r=Veykril
Implement invocation location config This allows setting the working directory for build-scripts on flycheck Complements rust-lang/rust-analyzer#13128 This will be followed up by one more PR that adds a few simple interpolation vars for `overrideCommand`, with that we should cover the needs for most build systems I believe.
Configuration menu - View commit details
-
Copy full SHA for b25f657 - Browse repository at this point
Copy the full SHA b25f657View commit details
Commits on Oct 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 859f559 - Browse repository at this point
Copy the full SHA 859f559View commit details -
Auto merge of rust-lang#13471 - Veykril:invoc-strategy-once, r=Veykril
Handle multiple projects sharing dependency correctly in `once` strategy
Configuration menu - View commit details
-
Copy full SHA for 43fb956 - Browse repository at this point
Copy the full SHA 43fb956View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b984e5 - Browse repository at this point
Copy the full SHA 8b984e5View commit details -
Enable varargs support for calling conventions other than C or cdecl
This patch makes it possible to use varargs for calling conventions, which are either based on C (like efiapi) or C is based on them (for example sysv64 and win64).
Configuration menu - View commit details
-
Copy full SHA for ba847ca - Browse repository at this point
Copy the full SHA ba847caView commit details -
Apply suggestions from code review
Use ticks around abis. Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 65ef625 - Browse repository at this point
Copy the full SHA 65ef625View commit details -
Configuration menu - View commit details
-
Copy full SHA for de78c32 - Browse repository at this point
Copy the full SHA de78c32View commit details
Commits on Oct 24, 2022
-
rustdoc: don't mark Box<T> as Iterator, Read, etc
Because Box<T> has pass-through implementations, rustdoc was giving it the "Notable Traits" treatment for Iterator, Read, Write, and Future, even when the type of T was unspecified. Pin had the same problem, but just for Future.
Configuration menu - View commit details
-
Copy full SHA for 63d1a72 - Browse repository at this point
Copy the full SHA 63d1a72View commit details
Commits on Oct 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c246a3d - Browse repository at this point
Copy the full SHA c246a3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 626d7fc - Browse repository at this point
Copy the full SHA 626d7fcView commit details -
llvm-16: Don't initialize removed legacy passes
LLVM removed initialization for legacy passes: https://reviews.llvm.org/D136615
Configuration menu - View commit details
-
Copy full SHA for 6ea75ae - Browse repository at this point
Copy the full SHA 6ea75aeView commit details
Commits on Oct 26, 2022
-
5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000 - Fix 410 gone response handling (rust-lang/cargo#11286) - Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281) - doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282) - Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280) - Add test for deleted index entry (rust-lang/cargo#11278)
Configuration menu - View commit details
-
Copy full SHA for 67c4c1f - Browse repository at this point
Copy the full SHA 67c4c1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c4a01a - Browse repository at this point
Copy the full SHA 0c4a01aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99a74af - Browse repository at this point
Copy the full SHA 99a74afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1946a18 - Browse repository at this point
Copy the full SHA 1946a18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22a6bc4 - Browse repository at this point
Copy the full SHA 22a6bc4View commit details -
Fix typo in docs for
guaranteed_ne
Lukas Markeffsky committedOct 26, 2022 Configuration menu - View commit details
-
Copy full SHA for cce46e9 - Browse repository at this point
Copy the full SHA cce46e9View commit details -
Rollup merge of rust-lang#97971 - Soveu:varargs, r=jackh726
Enable varargs support for calling conventions other than C or cdecl This patch makes it possible to use varargs for calling conventions, which are either based on C (efiapi) or C is based on them (sysv64 and win64). Also pinging ``@phlopsi,`` because he noticed first this oversight when writing a library for UEFI.
Configuration menu - View commit details
-
Copy full SHA for 8b001e6 - Browse repository at this point
Copy the full SHA 8b001e6View commit details -
Rollup merge of rust-lang#100452 - ouz-a:issue-93242, r=jackh726
Fake capture closures if typeck results are empty This ICE happens because `closure_min_captures` is empty, the reason it's empty is with the 2021 edition `enable_precise_capture` is set to true, which makes it so that we can't fake capture any information because that result of the `unwrap` is none hence the ICE. Other solution is editing [maybe_read_scrutinee](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_typeck/expr_use_visitor.rs.html#453-463) to this since empty slice contains no sub patterns. Fixes rust-lang#93242 ```rust PatKind::Slice(_, ref slice, _) => { if slice.is_none(){ need_to_be_read = true; } } // instead of PatKind::Or(_) | PatKind::Box(_) | PatKind::Slice(..) | PatKind::Ref(..) | PatKind::Wild => {} ```
Configuration menu - View commit details
-
Copy full SHA for 355e23e - Browse repository at this point
Copy the full SHA 355e23eView commit details -
Rollup merge of rust-lang#102101 - BelovDV:new-check-lld-version, r=p…
…etrochenkov check lld version to choose correct option to disable multi-threading in tests Testing compiler with 'use-lld = true' may be incorrect with old lld. Flag, disabling multi-threading, should consider lld version. r? `@petrochenkov`
Configuration menu - View commit details
-
Copy full SHA for 485adb5 - Browse repository at this point
Copy the full SHA 485adb5View commit details -
Rollup merge of rust-lang#103432 - jsha:box-is-not-notable, r=Guillau…
…meGomez rustdoc: don't mark Box<T> as Iterator, Read, etc Because Box<T> has pass-through implementations, rustdoc was giving it the "Notable Traits" treatment for Iterator, Read, Write, and Future, even when the type of T was unspecified. Pin had the same problem, but just for Future. Fixes rust-lang#100320
Configuration menu - View commit details
-
Copy full SHA for 978597f - Browse repository at this point
Copy the full SHA 978597fView commit details -
Rollup merge of rust-lang#103526 - Rageking8:more-dupe-typos-again, r…
…=Mark-Simulacrum More dupe typos again There are some others in submodules, which I will file separate PRs for in their respective repos. Thanks.
Configuration menu - View commit details
-
Copy full SHA for 150dbca - Browse repository at this point
Copy the full SHA 150dbcaView commit details -
Rollup merge of rust-lang#103537 - notriddle:notriddle/line-numbers, …
…r=GuillaumeGomez rustdoc: combine shared CSS between `.*-line-numbers` Example: https://notriddle.com/notriddle-rustdoc-demos/line-numbers/test_dingus/fn.test.html This PR should result in no visible changes. The example is here, so it can be easily tested in different browsers.
Configuration menu - View commit details
-
Copy full SHA for c5b04de - Browse repository at this point
Copy the full SHA c5b04deView commit details -
Rollup merge of rust-lang#103549 - maurer:llvm-main, r=cuviper
llvm-16: Don't initialize removed legacy passes LLVM removed initialization for legacy passes: https://reviews.llvm.org/D136615
Configuration menu - View commit details
-
Copy full SHA for 758a99f - Browse repository at this point
Copy the full SHA 758a99fView commit details -
Rollup merge of rust-lang#103558 - weihanglo:update-cargo, r=weihanglo
Update cargo 5 commits in 071eeaf210708219a5a1b2c4728ca2f97df7f2ae..9210810d1fd7b51ae0439a0a363cc50e36963455 2022-10-22 01:17:55 +0000 to 2022-10-25 22:31:50 +0000 - Fix 410 gone response handling (rust-lang/cargo#11286) - Fix inequality in "stale mtime" log messages (rust-lang/cargo#11281) - doc(cargo-tree): mention it considering feature unification (rust-lang/cargo#11282) - Improve the error message if `publish` is `false` or empty list (rust-lang/cargo#11280) - Add test for deleted index entry (rust-lang/cargo#11278)
Configuration menu - View commit details
-
Copy full SHA for 29ad394 - Browse repository at this point
Copy the full SHA 29ad394View commit details -
Rollup merge of rust-lang#103567 - RalfJung:ptr-eq-dyn-trait, r=dtolnay
ptr::eq: clarify that comparing dyn Trait is fragile Also remove the dyn trait example from `ptr::eq` since those tests are not actually guaranteed to pass due to how unstable vtable comparison is. Cc `@rust-lang/libs-api` Cc discussion following rust-lang#80505
Configuration menu - View commit details
-
Copy full SHA for f619f01 - Browse repository at this point
Copy the full SHA f619f01View commit details -
Rollup merge of rust-lang#103579 - lnicola:rust-analyzer-2022-10-26, …
…r=lnicola ⬆️ rust-analyzer r? `@ghost`
Configuration menu - View commit details
-
Copy full SHA for 2f21ead - Browse repository at this point
Copy the full SHA 2f21eadView commit details -
Rollup merge of rust-lang#103580 - lukas-code:guaranteed_ne, r=Guilla…
…umeGomez Fix typo in docs for `guaranteed_ne` `==` -> `!=`
Configuration menu - View commit details
-
Copy full SHA for 39796bd - Browse repository at this point
Copy the full SHA 39796bdView commit details