Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to collections docs to extend trait #110047

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Add link to collections docs to extend trait #110047

merged 1 commit into from
Apr 14, 2023

Conversation

skaunov
Copy link
Contributor

@skaunov skaunov commented Apr 7, 2023

I believe it would be useful here.

@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 7, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-log-analyzer

This comment has been minimized.

@skaunov
Copy link
Contributor Author

skaunov commented Apr 7, 2023

The job mingw-check-tidy failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)

I guess it requires to run cargo fmt. =( Will do when reclaim enough free space at my disk to checkout locally.

@ChrisDenton
Copy link
Member

While you're there, do you think linking collect to Iterator::collect would also be useful?

@skaunov
Copy link
Contributor Author

skaunov commented Apr 14, 2023

Sure! Frankly, I would also link std::iter high-level page in the beginning of the https://doc.rust-lang.org/stable/std/collections/index.html#iterators section. Do you think it's appropriate?

While you're there

@ChrisDenton
Copy link
Member

That definitely makes sense to me. Feel free to try it and I'll see how it looks.

@ChrisDenton
Copy link
Member

Ok, this is looking great. The only thing is there are now quite a few commits. Would you be able to squish them into one?

@skaunov
Copy link
Contributor Author

skaunov commented Apr 14, 2023

Sure. Just let me clone it again locally a bit later.

and couple of its methods
@skaunov
Copy link
Contributor Author

skaunov commented Apr 14, 2023

Thank you for bearing with me on this one! Can I ask a side question while CI checks squashing...

Why do I get the following output when command cargo fmt in the module dir? What's the trick to make it work like in simpler crates? =(

`cargo metadata` exited with an error: error: failed to load manifest for workspace member `/home/serge/Desktop/rust/src/tools/cargo`

Caused by:
  failed to read `/home/serge/Desktop/rust/src/tools/cargo/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
cargo-fmt 
...

@ChrisDenton
Copy link
Member

Ah, Rust's build system is fairly complex and complicated further by the fact it's building the compiler and tools that are used to build itself. If that makes sense.

So you have to use the x command instead. E.g. ./x fmt. See the dev guide.

@ChrisDenton
Copy link
Member

If you're interested in some of the details of the compiler's build system then Joshua Nelson's conference talk may be of interest: https://www.youtube.com/watch?v=oUIjG-y4zaA

@ChrisDenton
Copy link
Member

Ok, let's try to get this merged!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 14, 2023

📌 Commit 18ca509 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2023
@skaunov
Copy link
Contributor Author

skaunov commented Apr 14, 2023

Totally! I was suspecting something like this.

Ah, Rust's build system is fairly complex and complicated further by the fact it's building the compiler and tools that are used to build itself. If that makes sense.

I was cautiously looking at this py file, but was afraid to sink in different nuances. X))

So you have to use the x command instead. E.g. ./x fmt. See the dev guide.

Thanks a lot: ton of new stuff and information!

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#103682 (Stabilize rustdoc `--test-run-directory`)
 - rust-lang#106249 (Create "suggested tests" tool in `rustbuild`)
 - rust-lang#110047 (Add link to `collections` docs to `extend` trait)
 - rust-lang#110269 (Add `tidy-alphabetical` to features in `core`)
 - rust-lang#110292 (Add `tidy-alphabetical` to features in `alloc` & `std`)
 - rust-lang#110305 (rustdoc-search: use ES6 `Map` and `Set` where they make sense)
 - rust-lang#110315 (Add a stable MIR way to get the main function)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7361b17 into rust-lang:master Apr 14, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants