Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tidy-alphabetical to features in core #110269

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

scottmcm
Copy link
Member

So that people have to keep them sorted in future, rather than just sticking them on the end where they conflict more often.

So that people have to keep them sorted in future.
@rustbot
Copy link
Collaborator

rustbot commented Apr 13, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 13, 2023
@rustbot

This comment was marked as resolved.

@klensy
Copy link
Contributor

klensy commented Apr 13, 2023

Why not other library crates too?

@jyn514
Copy link
Member

jyn514 commented Apr 13, 2023

r=me unless you want to wait for a t-libs reviewer

@scottmcm
Copy link
Member Author

This is easy enough to undo later if libs-impl feels strongly, so I'll just
@bors r=jyn514

@klensy I'll make more PRs for more crates. I always start with just one to gauge interest.

@bors
Copy link
Contributor

bors commented Apr 13, 2023

📌 Commit 7407668 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 14, 2023
Add `tidy-alphabetical` to features in `core`

So that people have to keep them sorted in future, rather than just sticking them on the end where they conflict more often.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 14, 2023
Add `tidy-alphabetical` to features in `alloc` & `std`

So that people have to keep them sorted in future, rather than just sticking them on the end where they conflict more often.

Follow-up to rust-lang#110269
cc `@jyn514`
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#103682 (Stabilize rustdoc `--test-run-directory`)
 - rust-lang#106249 (Create "suggested tests" tool in `rustbuild`)
 - rust-lang#110047 (Add link to `collections` docs to `extend` trait)
 - rust-lang#110269 (Add `tidy-alphabetical` to features in `core`)
 - rust-lang#110292 (Add `tidy-alphabetical` to features in `alloc` & `std`)
 - rust-lang#110305 (rustdoc-search: use ES6 `Map` and `Set` where they make sense)
 - rust-lang#110315 (Add a stable MIR way to get the main function)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e79fc5b into rust-lang:master Apr 14, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 14, 2023
@scottmcm scottmcm deleted the sort-features branch April 14, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants