rustdoc-search: use ES6 Map and Set where they make sense
#110305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
notriddle
force-pushed
the
notriddle/es6-map-set
branch
from
3124256
to
53f499d
Compare
notriddle
commented
Apr 14, 2023
Comment on lines
-1117
to
-1130
| let match = null; | ||
| if (elems[generic.name]) { | ||
| match = generic.name; | ||
| } else { | ||
| for (const elem_name in elems) { | ||
| if (!hasOwnPropertyRustdoc(elems, elem_name)) { | ||
| continue; | ||
| } | ||
| if (elem_name === generic) { | ||
| match = elem_name; | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This version of the code was a bit messed up.
The original version of this code from d7971e5 was built to search the generics list for the lowest Levenshtein edit distance.
It was changed in be41750 to not check levenshtein distance any more, but this code remained, vestigial since it's comparing an object with a string and therefore can never find a match.
GuillaumeGomez
approved these changes
Apr 14, 2023
|
Nice improvement, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#103682 (Stabilize rustdoc `--test-run-directory`) - rust-lang#106249 (Create "suggested tests" tool in `rustbuild`) - rust-lang#110047 (Add link to `collections` docs to `extend` trait) - rust-lang#110269 (Add `tidy-alphabetical` to features in `core`) - rust-lang#110292 (Add `tidy-alphabetical` to features in `alloc` & `std`) - rust-lang#110305 (rustdoc-search: use ES6 `Map` and `Set` where they make sense) - rust-lang#110315 (Add a stable MIR way to get the main function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all supported browsers now support these classes, and rustdoc has started using them in some places, it might as well use them everywhere it makes sense (because, as MDN's Map page says, it "performs better in scenarios involving frequent additions and removals of key-value pairs.").