-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #110993
Rollup of 7 pull requests #110993
Commits on Apr 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4f7b895 - Browse repository at this point
Copy the full SHA 4f7b895View commit details -
Rename some suggestion/note functions
We really shouldn't be naming functions `fn check_*` unless they're doing *typechecking*. It's especially misleading when we're doing this inside of HIR typeck.
Configuration menu - View commit details
-
Copy full SHA for ab99cdf - Browse repository at this point
Copy the full SHA ab99cdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf24419 - Browse repository at this point
Copy the full SHA cf24419View commit details
Commits on Apr 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2bf5f77 - Browse repository at this point
Copy the full SHA 2bf5f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4edba55 - Browse repository at this point
Copy the full SHA 4edba55View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb00459 - Browse repository at this point
Copy the full SHA eb00459View commit details
Commits on Apr 28, 2023
-
Add support for LibreSSL 3.7.x
This updates the `openssl-sys` crate to 0.9.87 to support building the toolchain against the system libraries provided by LibreSSL version 3.7.x. LibreSSL 3.7.x has been supported since `openssl-sys` version 0.9.85.
Configuration menu - View commit details
-
Copy full SHA for 21ae5bd - Browse repository at this point
Copy the full SHA 21ae5bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc94522 - Browse repository at this point
Copy the full SHA dc94522View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10c77b1 - Browse repository at this point
Copy the full SHA 10c77b1View commit details -
rustdoc: fix weird margins between Deref impl items
In the old setup, if the dereffed-to item has multiple impl blocks, each one gets its own `div.impl-items` in the section, but there are no headers separating them. Since the last method in a `div.impl-items` has no bottom margin, and there are no margins between these divs, there is no margin between the last method of one impl and the first method of the following impl. This patch fixes it by simplifying the HTML. Each Deref block gets exactly one `div.impl-items`, no matter how many impl blocks it actually has.
Configuration menu - View commit details
-
Copy full SHA for 2299ba1 - Browse repository at this point
Copy the full SHA 2299ba1View commit details
Commits on Apr 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 47fb8e6 - Browse repository at this point
Copy the full SHA 47fb8e6View commit details -
windows: kill rust-analyzer-proc-macro-srv before deleting stage0 dir…
…ectory This fixes the following recurring error on windows: ``` Traceback (most recent call last): File "C:\Users\jyn\src\rust\x.py", line 29, in <module> bootstrap.main() File "C:\Users\jyn\src\rust\src\bootstrap\bootstrap.py", line 963, in main bootstrap(args) File "C:\Users\jyn\src\rust\src\bootstrap\bootstrap.py", line 927, in bootstrap build.download_toolchain() File "C:\Users\jyn\src\rust\src\bootstrap\bootstrap.py", line 437, in download_toolchain shutil.rmtree(bin_root) File "C:\Users\jyn\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 759, in rmtree return _rmtree_unsafe(path, onerror) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\jyn\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 617, in _rmtree_unsafe _rmtree_unsafe(fullname, onerror) File "C:\Users\jyn\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 622, in _rmtree_unsafe onerror(os.unlink, fullname, sys.exc_info()) File "C:\Users\jyn\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 620, in _rmtree_unsafe os.unlink(fullname) PermissionError: [WinError 5] Access is denied: 'C:\\Users\\jyn\\src\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\rust-analyzer-proc-macro-srv.exe' ```
Configuration menu - View commit details
-
Copy full SHA for 500c19c - Browse repository at this point
Copy the full SHA 500c19cView commit details -
Add
rustdoc::unescaped_backtick
lintLukas Markeffsky committedApr 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 4f15a77 - Browse repository at this point
Copy the full SHA 4f15a77View commit details -
Rollup merge of rust-lang#105848 - lukas-code:backticks, r=GuillaumeG…
…omez,jyn514,notriddle rustdoc: Add a new lint for broken inline code This patch adds `rustdoc::unescaped_backticks`, a new rustdoc lint that will detect broken inline code nodes. The lint woks by finding stray backticks and with some heuristics tries to guess where the second backtick might be missing. Here is how it looks: ```rust #![warn(rustdoc::unescaped_backticks)] /// `add(a, b) is the same as `add(b, a)`. pub fn add(a: i32, b: i32) -> i32 { a + b } ``` ```text warning: unescaped backtick --> src/lib.rs:3:41 | 3 | /// `add(a, b) is the same as `add(b, a)`. | ^ | help: a previous inline code might be longer than expected | 3 | /// `add(a, b)` is the same as `add(b, a)`. | + help: if you meant to use a literal backtick, escape it | 3 | /// `add(a, b) is the same as `add(b, a)\`. | + ``` If we can't get proper spans, for example if the doc comment comes from a macro expansion, we print the suggestion in help messages instead. Here's a [real-world example](https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/layer/trait.Filter.html#method.max_level_hint): ```text warning: unescaped backtick --> /tracing-subscriber-0.3.17/src/layer/mod.rs:1400:9 | 1400 | / /// Returns an optional hint of the highest [verbosity level][level] that 1401 | | /// this `Filter` will enable. 1402 | | /// 1403 | | /// If this method returns a [`LevelFilter`], it will be used as a hint to ... | 1427 | | /// [`Interest`]: tracing_core::subscriber::Interest 1428 | | /// [rebuild]: tracing_core::callsite::rebuild_interest_cache | |_____________________________________________________________________^ | = help: a previous inline code might be longer than expected change: Therefore, if the `Filter will change the value returned by this to this: Therefore, if the `Filter` will change the value returned by this = help: if you meant to use a literal backtick, escape it change: [`rebuild_interest_cache`][rebuild] is called after the value of the max to this: [`rebuild_interest_cache\`][rebuild] is called after the value of the max ``` You can find more examples [here](https://gist.github.com/lukas-code/7678ddf5c608aee97b3a669de80d3465). A limitation of the current implementation is, that it cannot suggest removing misplaced backticks, for example [here](https://docs.rs/tikv-jemalloc-sys/0.5.3+5.3.0-patched/tikv_jemalloc_sys/fn.mallctl.html). The lint is allowed by default ~~and nightly-only~~ for now, ~~but without a feature gate. This is similar to how `rustdoc::invalid_html_tags` and `rustdoc::bare_urls` were handled.~~
Configuration menu - View commit details
-
Copy full SHA for 4cfaead - Browse repository at this point
Copy the full SHA 4cfaeadView commit details -
Rollup merge of rust-lang#110504 - compiler-errors:tweak-borrow-sugg,…
… r=cjgillot Tweak borrow suggestion span Avoids a `span_to_snippet` call when we don't need to surround the expression in parentheses. The fact that the suggestion was using the whole span of the expression rather than just appending a `&` was prevented me from using `// run-rustfix` in another PR (rust-lang#110432 (comment)). Also some drive-by renames of functions that have been annoying me for a bit.
Configuration menu - View commit details
-
Copy full SHA for 07bf250 - Browse repository at this point
Copy the full SHA 07bf250View commit details -
Rollup merge of rust-lang#110644 - pietroalbini:pa-json-formatting-te…
…sts, r=Mark-Simulacrum Update tests for libtest `--format json` This PR makes the test work on beta and stable, and adds a test ensuring the option is not available on beta and stable. Backported these commits from rust-lang#110414.
Configuration menu - View commit details
-
Copy full SHA for af07ca6 - Browse repository at this point
Copy the full SHA af07ca6View commit details -
Rollup merge of rust-lang#110950 - JohnBobbo96:rustc_arena_unsafe_fn,…
… r=Nilstrieb Deny the `unsafe_op_in_unsafe_fn` lint in `rustc_arena`. r? ``@Nilstrieb``
Configuration menu - View commit details
-
Copy full SHA for c1d876f - Browse repository at this point
Copy the full SHA c1d876fView commit details -
Rollup merge of rust-lang#110951 - mixi:libressl-3.7.x, r=Mark-Simula…
…crum Add support for LibreSSL 3.7.x This updates the `openssl-sys` crate to 0.9.87 to support building the toolchain against the system libraries provided by LibreSSL version 3.7.x. LibreSSL 3.7.x has been supported since `openssl-sys` version 0.9.85.
Configuration menu - View commit details
-
Copy full SHA for da3e8e4 - Browse repository at this point
Copy the full SHA da3e8e4View commit details -
Rollup merge of rust-lang#110964 - notriddle:notriddle/deref-impl, r=…
…GuillaumeGomez rustdoc: fix weird margins between Deref impl items ## Before ![image](https://user-images.githubusercontent.com/1593513/235245977-90770591-22c1-4a27-9464-248a3729a2b7.png) ## After ![image](https://user-images.githubusercontent.com/1593513/235246009-0e83113e-42b7-4e29-981d-969f9d20af01.png) ## Description In the old setup, if the dereffed-to item has multiple impl blocks, each one gets its own `div.impl-items` in the section, but there are no headers separating them. Since the last method in a `div.impl-items` has no bottom margin, and there are no margins between these divs, there is no margin between the last method of one impl and the first method of the following impl. This patch fixes it by simplifying the HTML. Each Deref block gets exactly one `div.impl-items`, no matter how many impl blocks it actually has.
Configuration menu - View commit details
-
Copy full SHA for 78eb6c2 - Browse repository at this point
Copy the full SHA 78eb6c2View commit details -
Rollup merge of rust-lang#110979 - jyn514:windows-locking, r=ChrisDenton
windows: kill rust-analyzer-proc-macro-srv before deleting stage0 directory This fixes the following recurring error on windows: ``` Traceback (most recent call last): File "C:\Users\jyn\src\rust\x.py", line 29, in <module> bootstrap.main() File "C:\Users\jyn\src\rust\src\bootstrap\bootstrap.py", line 963, in main bootstrap(args) File "C:\Users\jyn\src\rust\src\bootstrap\bootstrap.py", line 927, in bootstrap build.download_toolchain() File "C:\Users\jyn\src\rust\src\bootstrap\bootstrap.py", line 437, in download_toolchain shutil.rmtree(bin_root) File "C:\Users\jyn\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 759, in rmtree return _rmtree_unsafe(path, onerror) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\jyn\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 617, in _rmtree_unsafe _rmtree_unsafe(fullname, onerror) File "C:\Users\jyn\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 622, in _rmtree_unsafe onerror(os.unlink, fullname, sys.exc_info()) File "C:\Users\jyn\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 620, in _rmtree_unsafe os.unlink(fullname) PermissionError: [WinError 5] Access is denied: 'C:\\Users\\jyn\\src\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\rust-analyzer-proc-macro-srv.exe' ``` Fixes rust-lang#107018. r? ``@ChrisDenton``
Configuration menu - View commit details
-
Copy full SHA for ad1d3da - Browse repository at this point
Copy the full SHA ad1d3daView commit details