impl Not, Bit{And,Or}{,Assign} for IP addresses

[clarfonthey]

ACP: rust-lang/libs-team#235

Note: since these are insta-stable, these require an FCP.

Implements, where N is either 4 or 6:

impl Not for IpvNAddr
impl Not for &IpvNAddr

impl BitAnd<IpvNAddr> for IpvNAddr
impl BitAnd<&IpvNAddr> for IpvNAddr
impl BitAnd<IpvNAddr> for &IpvNAddr
impl BitAnd<&IpvNAddr> for &IpvNAddr

impl BitAndAssign<IpvNAddr> for IpvNAddr
impl BitAndAssign<&IpvNAddr> for IpvNAddr

impl BitOr<IpvNAddr> for IpvNAddr
impl BitOr<&IpvNAddr> for IpvNAddr
impl BitOr<IpvNAddr> for &IpvNAddr
impl BitOr<&IpvNAddr> for &IpvNAddr

impl BitOrAssign<IpvNAddr> for IpvNAddr
impl BitOrAssign<&IpvNAddr> for IpvNAddr

[rustbot]

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

[clarfonthey]

Gentle nudge to @joshtriplett if you could start the FCP.

[dtolnay]

@rust-lang/libs-api:
@rfcbot fcp merge

The following 28 impls, per ACP in rust-lang/libs-team#235:

impl Not for Ipv4Addr
impl Not for &Ipv4Addr

impl BitAnd<Ipv4Addr> for Ipv4Addr
impl BitAnd<&Ipv4Addr> for Ipv4Addr
impl BitAnd<Ipv4Addr> for &Ipv4Addr
impl BitAnd<&Ipv4Addr> for &Ipv4Addr

impl BitAndAssign<Ipv4Addr> for Ipv4Addr
impl BitAndAssign<&Ipv4Addr> for Ipv4Addr

impl BitOr<Ipv4Addr> for Ipv4Addr
impl BitOr<&Ipv4Addr> for Ipv4Addr
impl BitOr<Ipv4Addr> for &Ipv4Addr
impl BitOr<&Ipv4Addr> for &Ipv4Addr

impl BitOrAssign<Ipv4Addr> for Ipv4Addr
impl BitOrAssign<&Ipv4Addr> for Ipv4Addr

// and s/Ipv4Addr/Ipv6Addr/g all of the above.

The quadruplication of BitAnd and BitOr, and duplication of Not, BitAndAssign, BitOrAssign, appears to be standard. We have the same for all of the integer primitives.

The other parts of the same ACP are in #113748 (insta-stable in 1.74) and #113746 (unstable).

[rfcbot]

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se

Concerns:

• for IpAddr resolved by impl Not, Bit{And,Or}{,Assign} for IP addresses #113747 (comment)

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[dtolnay]

@rfcbot concern for IpAddr

Let's cut impl Not for IpAddr and impl Not for &IpAddr. I don't understand the use case for those.

[clarfonthey]

Rebased and removed the Not for IpAddr impls, since I had already commented that I didn't think they were super necessary either.

Also stole borrowed the comment from @dtolnay on what impls were added and put it in the description.

[dtolnay]

@rfcbot resolve for IpAddr

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

[dtolnay]

Thanks!

[dtolnay]

@bors r+

[bors]

📌 Commit 6b13950 has been approved by dtolnay

It is now in the queue for this repository.

[bors]

⌛ Testing commit 6b13950 with merge 30d310c...

[bors]

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 30d310c to master...

[rust-timer]

Finished benchmarking commit (30d310c): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	0.5%	[0.5%, 0.5%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[1.5%, 3.1%]	2
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-2.1%, 3.1%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 623.806s -> 624.787s (0.16%)
Artifact size: 305.51 MiB -> 305.54 MiB (0.01%)