Rollup of 3 pull requests

[GuillaumeGomez]

Successful merges:

• Implement OnceCell/Lock::try_insert() #116540 (Implement OnceCell/Lock::try_insert())
• const-eval: allow calling functions with targat features disabled at compile time in WASM #116576 (const-eval: allow calling functions with targat features disabled at compile time in WASM)
• Make "request changes" reviews apply S-waiting-on-author #116661 (Make "request changes" reviews apply S-waiting-on-author)

Failed merges:

• x.py zsh completion support #116643 (x.py zsh completion support)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[GuillaumeGomez]

@bors r+ p=4 rollup=never

[bors]

📌 Commit 31b86ea has been approved by GuillaumeGomez

It is now in the queue for this repository.

[bors]

⌛ Testing commit 31b86ea with merge e292fec...

[bors]

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing e292fec to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#116540	Implement OnceCell/Lock::try_insert()	89ce142e4de461aaa8f77b99914f0ff4b287105e (link)
#116576	const-eval: allow calling functions with targat features di…	22ad6757beafbc14ac24d7fcb9e4efeca6268597 (link)
#116661	Make "request changes" reviews apply S-waiting-on-author	eca370fb29392958c6234cf2edfc189435f22ea1 (link)

previous master: c543b6f351

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (e292fec): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.4%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.3%, 0.4%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-4.0%	[-5.1%, -3.0%]	2
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 623.517s -> 624.559s (0.17%)
Artifact size: 305.48 MiB -> 305.55 MiB (0.02%)

[pnkfelix]

Visiting for weekly perf triage.

• Regressions are solely to three bitmaps-3.1.0 full scenarios.
• Looks like a blip (i.e. noise) based on the graph over time for the three cases.
• marking as triaged.

@rustbot label: +perf-regression-triaged