add test for wasm linker override=clang

[reez12g]

addressing #109728

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

Test itself seems fine to me, is there a reason this is in draft mode?

[reez12g]

Thanks!
CI passed, so I remove the draft status.

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit 93d8d2e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

⌛ Testing commit 93d8d2e with merge c90dec4...

[bors]

💔 Test failed - checks-actions

[reez12g]

In that case, should we include a command in the Makefile to install clang? Perhaps something like this:
sudo apt-get install clang && $(RUSTC) foo.rs --crate-type cdylib --target $(TARGET) -C linker=clang

[Mark-Simulacrum]

tests/run-make/issue-84395-lto-embed-bitcode/Makefile also requires CLANG -- I think you can set this test up the same way, which should hopefully work and still run in CI.

The test-various builder already includes clang: https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/test-various/Dockerfile#L5, so I suspect this could have worked, just a matter of not finding it. It's possible that we could add a needs-clang attribute similar to the one in the lto-embed-bitcode test but more generic, if we have to run on test-various.

The tests themselves shouldn't install via apt or similar though.

[reez12g]

Thanks!
I modified the linker argument.

[Mark-Simulacrum]

@bors r+ rollup=iffy

I'm not sure if that's enough without needs-matching-clang in terms of filtering for platforms with clang, but let's see what CI says.

[bors]

📌 Commit b9f92a8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

⌛ Testing commit b9f92a8 with merge 23098d0...

[bors]

💔 Test failed - checks-actions

[Mark-Simulacrum]

@bors retry

[bors]

⌛ Testing commit b9f92a8 with merge d0c235e...

[bors]

💔 Test failed - checks-actions

[reez12g]

I added # needs-matching-clang

[Mark-Simulacrum]

@bors r+ rollup=iffy

Alright, let's try that.

[bors]

📌 Commit 4fa4758 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4fa4758 with merge 8de6f99...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 8de6f99 to master...

[rust-timer]

Finished benchmarking commit (8de6f99): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[0.8%, 4.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.4%, -0.9%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[-1.4%, 4.3%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 627.524s -> 628.69s (0.19%)
Artifact size: 271.31 MiB -> 271.35 MiB (0.01%)