Clean up rustdoc css #40278
Clean up rustdoc css #40278
Conversation
|
To summarize a bit what I did:
|
I am not a fan of this, but if everyone else wants to, i will not fight it |
|
It's css and it's already the case for almost every line. |
CSS doesn't need to use tabs. In fact, this is the first time I've seen CSS with tabs.
This argument makes more sense though. In general, I'm in favor of spaces over tabs, but in this case, consistency seems more important. We can discuss about potentially migrating to spaces in a different PR. |
|
|
Simply because they generally use minifier in order to reduce network impact. However, in CSS it's still the norm to use tabs as far as I can tell. |
|
☔ The latest upstream changes (presumably #40368) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
css-cleanup
branch
from
e45bdf6
to
79d88e7
Compare
GuillaumeGomez
force-pushed
the
css-cleanup
branch
from
79d88e7
to
4078b25
Compare
|
Updated. |
|
Have you tested to make sure this doesn't affect the new sidebar changes? If so, r=me |
|
It just moves color setting from one file to another, nothing else. I can still confirm otherwise if you want to be absolutely sure. As your prefer. |
|
@bors r+ rollup |
|
📌 Commit 4078b25 has been approved by |
Clean up rustdoc css r? @rust-lang/docs
Clean up rustdoc css r? @rust-lang/docs
Clean up rustdoc css r? @rust-lang/docs
Clean up rustdoc css r? @rust-lang/docs
Clean up rustdoc css r? @rust-lang/docs
Clean up rustdoc css r? @rust-lang/docs
Clean up rustdoc css r? @rust-lang/docs
Clean up rustdoc css r? @rust-lang/docs
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
r? @rust-lang/docs