-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish the ways CStr::from_bytes_with_nul
can fail
#40386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
added
the
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
label
Mar 9, 2017
This looks reasonable to me - @alexcrichton seem that way to you too? |
@bors: r+ |
📌 Commit da6e7c8 has been approved by |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
alexcrichton
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 10, 2017
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 11, 2017
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
bors
added a commit
that referenced
this pull request
Mar 11, 2017
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 11, 2017
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
bors
added a commit
that referenced
this pull request
Mar 11, 2017
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.