Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement placement-in protocol for VecDeque #40389

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Implement placement-in protocol for VecDeque #40389

merged 1 commit into from
Mar 11, 2017

Conversation

F001
Copy link
Contributor

@F001 F001 commented Mar 9, 2017

CC #30172

r? @nagisa

@F001 F001 changed the title Implement placement-in protocol for and VecDeque Implement placement-in protocol for VecDeque Mar 9, 2017
@nagisa
Copy link
Member

nagisa commented Mar 9, 2017

Looks great to me.

@aturon
Copy link
Member

aturon commented Mar 9, 2017

@bors delegate=nagisa

@bors
Copy link
Contributor

bors commented Mar 9, 2017

✌️ @nagisa can now approve this pull request

@nagisa
Copy link
Member

nagisa commented Mar 9, 2017

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Mar 9, 2017

📌 Commit 8062cfb has been approved by nagisa

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 9, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
alexcrichton pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
Implement placement-in protocol for `VecDeque`

CC rust-lang#30172

r? @nagisa
reason = "placement protocol is subject to change",
issue = "30172")]
impl<'a, T> Placer<T> for PlaceBack<'a, T> {
type Place = PlaceBack<'a, T>;
Copy link
Contributor

@tikue tikue Mar 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be type Place = Self?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's the same. And I don't bias towards any one.

@bors bors merged commit 8062cfb into rust-lang:master Mar 11, 2017
@F001 F001 deleted the placementVecDeque branch March 11, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants