-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement placement-in protocol for VecDeque
#40389
Conversation
VecDeque
VecDeque
Looks great to me. |
@bors delegate=nagisa |
✌️ @nagisa can now approve this pull request |
@bors r+ Thanks! |
📌 Commit 8062cfb has been approved by |
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
reason = "placement protocol is subject to change", | ||
issue = "30172")] | ||
impl<'a, T> Placer<T> for PlaceBack<'a, T> { | ||
type Place = PlaceBack<'a, T>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be type Place = Self
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It's the same. And I don't bias towards any one.
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
CC #30172
r? @nagisa