-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 22 pull requests #55347
Rollup of 22 pull requests #55347
Commits on Sep 3, 2018
-
The whole keyword docs thing is pretty new in Rust's history and needs some work before it's a shining gem. Here's hoping I can provide that. I basically shoved in a bunch of the most important information from the reference and the book, along with leaving links to both at the end. I don't think keyword docs need to have complete detail, just all the broad strokes, so if someone's confused about a usage of a keyword they can look at the std documentation for that keyword.
Configuration menu - View commit details
-
Copy full SHA for 047aac5 - Browse repository at this point
Copy the full SHA 047aac5View commit details -
It's pretty basic and could do with more details, but it's a good starter until someone else improves it.
Configuration menu - View commit details
-
Copy full SHA for 1142bbd - Browse repository at this point
Copy the full SHA 1142bbdView commit details -
Turns out writing docs on keywords that are used in multiple different places in entirely different contexts gets a little harder. I put a footnote on `*const` syntax just to make sure you can find it if need be, but it might need more detail.
Configuration menu - View commit details
-
Copy full SHA for c1bd8a9 - Browse repository at this point
Copy the full SHA c1bd8a9View commit details -
Fix a few small things, re-word others
Mostly addressing notes on ambiguous syntax and spurious newlines.
Configuration menu - View commit details
-
Copy full SHA for 6cbcfa2 - Browse repository at this point
Copy the full SHA 6cbcfa2View commit details
Commits on Sep 5, 2018
-
I think it might be used in some other things, but I'm not fluent enough at sifting through the rust compiler's source code to find every use of a specific keyword. This leaves the question of how to document the `extern` keyword, what with how much overlap it has with `crate`, but that's used with ABI stuff so that should be fine.
Configuration menu - View commit details
-
Copy full SHA for f8d6261 - Browse repository at this point
Copy the full SHA f8d6261View commit details
Commits on Sep 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f15a1ec - Browse repository at this point
Copy the full SHA f15a1ecView commit details
Commits on Sep 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f91ad44 - Browse repository at this point
Copy the full SHA f91ad44View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5c4a38 - Browse repository at this point
Copy the full SHA a5c4a38View commit details
Commits on Sep 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f7a6638 - Browse repository at this point
Copy the full SHA f7a6638View commit details
Commits on Sep 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5d05ae7 - Browse repository at this point
Copy the full SHA 5d05ae7View commit details
Commits on Sep 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5393b27 - Browse repository at this point
Copy the full SHA 5393b27View commit details
Commits on Sep 19, 2018
-
This commit also splits out linky-line-thingies into two lines, which judging from the source code for tidy, should be enough to make it shut up and accept me for who I am, dammit.
Configuration menu - View commit details
-
Copy full SHA for 738e58d - Browse repository at this point
Copy the full SHA 738e58dView commit details -
It didn't strictly need to be reworked and I'm not sure my version is better, but oh well, I'm doing it for consistency.
Configuration menu - View commit details
-
Copy full SHA for 165690b - Browse repository at this point
Copy the full SHA 165690bView commit details
Commits on Sep 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 76a353b - Browse repository at this point
Copy the full SHA 76a353bView commit details
Commits on Sep 26, 2018
-
Removed dead links to unwritten keyword docs
Most of these will eventually be filled, but right now travis-ci enjoys complaining about the fact that there's links that lead nowhere, so they're gone. Hopefully someone remembers to re-add them later.
Configuration menu - View commit details
-
Copy full SHA for 50f631c - Browse repository at this point
Copy the full SHA 50f631cView commit details -
Incorporate criticisms into keyword docs
Thanks to @Centril for these.
Configuration menu - View commit details
-
Copy full SHA for 577dbc8 - Browse repository at this point
Copy the full SHA 577dbc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 619dfeb - Browse repository at this point
Copy the full SHA 619dfebView commit details
Commits on Oct 10, 2018
-
update tcp stream documentation
Charles Hathaway committedOct 10, 2018 Configuration menu - View commit details
-
Copy full SHA for c514b62 - Browse repository at this point
Copy the full SHA c514b62View commit details -
Accept
Option<Box<$t:ty>>
in macro argumentGiven the following code, compile successfuly: ``` macro_rules! test { ( fn fun() -> Option<Box<$t:ty>>; ) => { fn fun(x: $t) -> Option<Box<$t>> { Some(Box::new(x)) } } } test! { fn fun() -> Option<Box<i32>>; } ```
Configuration menu - View commit details
-
Copy full SHA for c77a0cf - Browse repository at this point
Copy the full SHA c77a0cfView commit details
Commits on Oct 11, 2018
-
Small changes to fix documentation auto compile issues
Charles Hathaway committedOct 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 4530b8c - Browse repository at this point
Copy the full SHA 4530b8cView commit details
Commits on Oct 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f8550a4 - Browse repository at this point
Copy the full SHA f8550a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a70ef6a - Browse repository at this point
Copy the full SHA a70ef6aView commit details
Commits on Oct 17, 2018
-
in which unused-parens suggestions heed what the user actually wrote
Aaron Hill pointed out that unnecessary parens around a macro call (paradigmatically, `format!`) yielded a suggestion of hideous macro-expanded code. (The slightly unusual choice of using the pretty-printer to compose suggestions was quite recently commented on in the commit message for 1081bbb ("abolish ICE when pretty-printing async block"), but without any grounds to condemn it as a 𝘣𝘢𝘥 choice. Hill's report provides the grounds.) `span_to_snippet` is fallable as far as the type system is concerned (because, who knows, macros or something), so the pretty-printing can live on in the oft-neglected `else` branch. Resolves rust-lang#55109.
Configuration menu - View commit details
-
Copy full SHA for 475be10 - Browse repository at this point
Copy the full SHA 475be10View commit details
Commits on Oct 21, 2018
-
submodules: update clippy from 5afdf8b to b1d0343
Changes: ```` new_ret_no_self: add sample from rust-lang#3313 to Known Problems section. Support multiline comments and hopefully fix panic Check for comments in collapsible ifs Resolve ICE in needless range loop lint RIIR update_lints: Update changelog links Rename if_let_redundant_pattern_matching to redundant_pattern_matching Add lint for redundant pattern matching for explicit return boolean Fix issue rust-lang#3322: reword help message for len_zero Simplify manual_memcpy suggestion in some cases Fix dogfood Update known problems for unnecessary_fold RIIR update_lints: Replace lint count in README.md Rename `active_lints` to `usable_lints` Add comment on WalkDir vs. fs::read_dir sort_by -> sort_by_key Some more documentation for clippy_dev Use `WalkDir` to also gather from subdirectories Avoid linting `boxed_local` on trait implementations. Website: Make lint categories linkable Restore clippy_dummy's placeholder name Swap order of methods in `needless_range_loop` suggestion in some cases Revert "Exclude pattern guards from unnecessary_fold lint" Exclude pattern guards from unnecessary_fold lint ````
Configuration menu - View commit details
-
Copy full SHA for 9378705 - Browse repository at this point
Copy the full SHA 9378705View commit details -
The example was not as clear as it could be because it was making an assumption about the structure of the data in order to multiply the number of collection elements by the item size. This change demonstrates the idea more straightforwardly, without the calculation.
Configuration menu - View commit details
-
Copy full SHA for 0f6e274 - Browse repository at this point
Copy the full SHA 0f6e274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f70096 - Browse repository at this point
Copy the full SHA 9f70096View commit details -
only issue "variant of the expected type" suggestion for enums
Felix S. Klock II pointed out that this suggestion (introduced in pull-request rust-lang#43178 / eac7410) was being issued for one-field-struct expected types (in which case it is misleading and outright wrong), even though it was only intended for one-field enum-variants (most notably, `Some`). Particularly tender-hearted code-historians may be inclined to show mercy towards the author of rust-lang#43178 on the grounds that it's somewhat confusing that struct field definitions are given in a type called `ty::VariantDef`. Add a conditional to adhere to the original intent. (It would be possible to generalize to structs, but not obviously net desirable.) This adds a level of indentation, so the diff here is going to be easier to read in ignore-whitespace mode (`-w`). Resolves rust-lang#55250.
Configuration menu - View commit details
-
Copy full SHA for b0d3d3b - Browse repository at this point
Copy the full SHA b0d3d3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c675111 - Browse repository at this point
Copy the full SHA c675111View commit details
Commits on Oct 22, 2018
-
Suggest appropriate syntax on missing lifetime specifier in return type
Suggest using `'static` when a lifetime is missing in the return type with a structured suggestion instead of a note.
Configuration menu - View commit details
-
Copy full SHA for e1e52eb - Browse repository at this point
Copy the full SHA e1e52ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0bd69a - Browse repository at this point
Copy the full SHA d0bd69aView commit details -
[review comments] modify test and clean up code
Co-Authored-By: estebank <esteban@kuber.com.ar>
Configuration menu - View commit details
-
Copy full SHA for dd91c8f - Browse repository at this point
Copy the full SHA dd91c8fView commit details
Commits on Oct 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fda3326 - Browse repository at this point
Copy the full SHA fda3326View commit details -
Do some copy editing on the release notes
I was reading through the release notes to find something and noticed some small grammatical and consistency issues.
Configuration menu - View commit details
-
Copy full SHA for 8d6ee8f - Browse repository at this point
Copy the full SHA 8d6ee8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4972bea - Browse repository at this point
Copy the full SHA 4972beaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d9231c - Browse repository at this point
Copy the full SHA 3d9231cView commit details -
This was added in the fortnight this PR spent stale. I'm hoping this one-liner fixes it.
Configuration menu - View commit details
-
Copy full SHA for 320ec81 - Browse repository at this point
Copy the full SHA 320ec81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3539132 - Browse repository at this point
Copy the full SHA 3539132View commit details -
Set RUST_BACKTRACE=0 for rustdoc-ui/failed-doctest-output.rs
This UI test is sensitive to backtrace output, so it should make sure that backtraces are not enabled by the environment.
Configuration menu - View commit details
-
Copy full SHA for f2443a9 - Browse repository at this point
Copy the full SHA f2443a9View commit details
Commits on Oct 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for be2075c - Browse repository at this point
Copy the full SHA be2075cView commit details -
Documents
From
implementations forStdio
Add a basic summary and an example to From `ChildStdin`, `ChildStdout`, `ChildStderr`, `File` implementations.
Configuration menu - View commit details
-
Copy full SHA for 0b82e03 - Browse repository at this point
Copy the full SHA 0b82e03View commit details -
Fix doc for new copysign functions
Thanks to @LukasKalbertodt for catching this. Addresses a comment raised in rust-lang#55169 after it was merged.
Configuration menu - View commit details
-
Copy full SHA for 538f65e - Browse repository at this point
Copy the full SHA 538f65eView commit details
Commits on Oct 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 431b254 - Browse repository at this point
Copy the full SHA 431b254View commit details -
It was confusingly named (`is_zero` would have been better), and it didn't even reliably test for "is this value 0 at run-time" because out-of-bounds pointers *can* be 0.
Configuration menu - View commit details
-
Copy full SHA for cbe6b22 - Browse repository at this point
Copy the full SHA cbe6b22View commit details -
Rollup merge of rust-lang#53507 - phungleson:fix-impl-from-for-waker,…
… r=cramertj Add doc for impl From for Waker As part of issue rust-lang#51430 (cc @skade). The impl is very simple, so not sure if we need to go into any details.
Configuration menu - View commit details
-
Copy full SHA for 18f7d41 - Browse repository at this point
Copy the full SHA 18f7d41View commit details -
Rollup merge of rust-lang#53931 - iirelu:keyword-docs, r=steveklabnik
Gradually expanding libstd's keyword documentation I'm working on adding new keywords to the documentation and refreshing the incomplete older ones, and I'm hoping that I can eventually add all the standalone-usable keywords after a bunch of incremental work. It would be cool to see the keywords section of std's docs be a definitive reference as to what each keyword means when you see it, and that's what I'm aiming towards with this work. I'm far from a Rust expert so there will inevitably be things to fix in this, also I'm not sure if this should be a bunch of quickly-merged PRs or one gradually-updated PR that gets merged once it's done.
Configuration menu - View commit details
-
Copy full SHA for 3bcfa07 - Browse repository at this point
Copy the full SHA 3bcfa07View commit details -
Rollup merge of rust-lang#54965 - chathaway-codes:update-tcp-stream-d…
…ocs, r=GuillaumeGomez update tcp stream documentation A small styling issue that seemed inconsistent here when compared to other places (such as https://doc.rust-lang.org/beta/std/net/struct.TcpListener.html).
Configuration menu - View commit details
-
Copy full SHA for 699f591 - Browse repository at this point
Copy the full SHA 699f591View commit details -
Rollup merge of rust-lang#54977 - estebank:macro-arg-parse, r=pnkfelix
Accept `Option<Box<$t:ty>>` in macro argument Given the following code, compile successfuly: ``` macro_rules! test { ( fn fun() -> Option<Box<$t:ty>>; ) => { fn fun(x: $t) -> Option<Box<$t>> { Some(Box::new(x)) } } } test! { fn fun() -> Option<Box<i32>>; } ``` Fix rust-lang#25274.
Configuration menu - View commit details
-
Copy full SHA for f81e47f - Browse repository at this point
Copy the full SHA f81e47fView commit details -
Rollup merge of rust-lang#55138 - zackmdavis:the_paren_trap, r=pnkfelix
in which unused-parens suggestions heed what the user actually wrote Aaron Hill pointed out that unnecessary parens around a macro call (paradigmatically, `format!`) yielded a suggestion of hideous macro-expanded code. `span_to_snippet` is fallable as far as the type system is concerned, so the pretty-printing can live on in the oft-neglected `else` branch. Resolves rust-lang#55109.
Configuration menu - View commit details
-
Copy full SHA for 6dfeb76 - Browse repository at this point
Copy the full SHA 6dfeb76View commit details -
Rollup merge of rust-lang#55173 - estebank:suggest-static, r=oli-obk
Suggest appropriate syntax on missing lifetime specifier in return type Suggest using `'static` when a lifetime is missing in the return type with a structured suggestion instead of a note. Fix rust-lang#55170.
Configuration menu - View commit details
-
Copy full SHA for f50e285 - Browse repository at this point
Copy the full SHA f50e285View commit details -
Rollup merge of rust-lang#55200 - octronics:gh51430, r=kennytm
Documents `From` implementations for `Stdio` This PR solves part of rust-lang#51430 by adding a basic summary and an example to each `impl From` inside `process` module (`ChildStdin`, `ChildStdout`, `ChildStderr`, `File`). It does not document if the conversions allocate memory and how expensive they are.
Configuration menu - View commit details
-
Copy full SHA for 49eb443 - Browse repository at this point
Copy the full SHA 49eb443View commit details -
Rollup merge of rust-lang#55245 - matthiaskrgr:clippy, r=nikomatsakis
submodules: update clippy from 5afdf8b to b1d0343 Just a routine update. Changes: ```` new_ret_no_self: add sample from rust-lang#3313 to Known Problems section. Support multiline comments and hopefully fix panic Check for comments in collapsible ifs Resolve ICE in needless range loop lint RIIR update_lints: Update changelog links Rename if_let_redundant_pattern_matching to redundant_pattern_matching Add lint for redundant pattern matching for explicit return boolean Fix issue rust-lang#3322: reword help message for len_zero Simplify manual_memcpy suggestion in some cases Fix dogfood Update known problems for unnecessary_fold RIIR update_lints: Replace lint count in README.md Rename `active_lints` to `usable_lints` Add comment on WalkDir vs. fs::read_dir sort_by -> sort_by_key Some more documentation for clippy_dev Use `WalkDir` to also gather from subdirectories Avoid linting `boxed_local` on trait implementations. Website: Make lint categories linkable Restore clippy_dummy's placeholder name Swap order of methods in `needless_range_loop` suggestion in some cases Revert "Exclude pattern guards from unnecessary_fold lint" Exclude pattern guards from unnecessary_fold lint ````
Configuration menu - View commit details
-
Copy full SHA for c4e51a2 - Browse repository at this point
Copy the full SHA c4e51a2View commit details -
Rollup merge of rust-lang#55247 - peterjoel:peterjoel-prim-char-doc-e…
…xample, r=joshtriplett Clarified code example in char primitive doc The example was not as clear as it could be because it was making an assumption about the structure of the data in order to multiply the number of elements in the slice by the item size. This change demonstrates the idea more straightforwardly, without needing a calculation, by just comparing the size of the slices.
Configuration menu - View commit details
-
Copy full SHA for f740b8a - Browse repository at this point
Copy the full SHA f740b8aView commit details -
Rollup merge of rust-lang#55251 - NieDzejkob:master, r=TimNN
Fix a typo in the documentation of RangeInclusive
Configuration menu - View commit details
-
Copy full SHA for 823244a - Browse repository at this point
Copy the full SHA 823244aView commit details -
Rollup merge of rust-lang#55253 - zackmdavis:some_suggestion, r=pnkfelix
only issue "variant of the expected type" suggestion for enums This suggestion (introduced in pull-request rust-lang#43178 / eac7410) was being issued for one-field-struct expected types (in which case it is misleading and outright wrong), even though it was only intended for one-field enum-variants (most notably, `Some`). Add a conditional to adhere to the original intent. (It would be possible to generalize to structs, but not obviously net desirable.) This adds a level of indentation, so the diff here is going to be easier to read in [ignore-whitespace mode](rust-lang@b0d3d3b9?w=1). Resolves rust-lang#55250. r? @pnkfelix
Configuration menu - View commit details
-
Copy full SHA for f46ee04 - Browse repository at this point
Copy the full SHA f46ee04View commit details -
Rollup merge of rust-lang#55254 - rust-lang:clean-two-dots, r=Guillau…
…meGomez Correct trailing ellipsis in name_from_pat r? @GuillaumeGomez
Configuration menu - View commit details
-
Copy full SHA for 88341a9 - Browse repository at this point
Copy the full SHA 88341a9View commit details -
Rollup merge of rust-lang#55269 - matthiaskrgr:typos_oct, r=zackmdavis
fix typos in various places
Configuration menu - View commit details
-
Copy full SHA for 4f14bfd - Browse repository at this point
Copy the full SHA 4f14bfdView commit details -
Rollup merge of rust-lang#55282 - sinkuu:redundant_clone, r=estebank
Remove redundant clone
Configuration menu - View commit details
-
Copy full SHA for 555df0f - Browse repository at this point
Copy the full SHA 555df0fView commit details -
Rollup merge of rust-lang#55285 - integer32llc:release-notes-improvem…
…ents, r=Aaronepower Do some copy editing on the release notes I was reading through the release notes to find something and noticed some small grammatical and consistency issues. I'm happy to revert any of these changes if folks disagree with them!
Configuration menu - View commit details
-
Copy full SHA for 539ee06 - Browse repository at this point
Copy the full SHA 539ee06View commit details -
Rollup merge of rust-lang#55291 - kazcw:master, r=nikomatsakis
Update stdsimd submodule Fixes a SSE2 bug. (rust-lang#55249)
Configuration menu - View commit details
-
Copy full SHA for c4723b3 - Browse repository at this point
Copy the full SHA c4723b3View commit details -
Rollup merge of rust-lang#55296 - cuviper:rustdoc-ui-backtrace, r=nik…
…omatsakis Set RUST_BACKTRACE=0 for rustdoc-ui/failed-doctest-output.rs This UI test is sensitive to backtrace output, so it should make sure that backtraces are not enabled by the environment.
Configuration menu - View commit details
-
Copy full SHA for 1220e13 - Browse repository at this point
Copy the full SHA 1220e13View commit details -
Rollup merge of rust-lang#55306 - pnkfelix:issue-54478-regression-tes…
…t-jemalloc-ctl, r=nikomatsakis Regression test for rust-lang#54478. This is a regression test for rust-lang#54478. I confirmed that it fails on: rustdoc 1.30.0-beta.12 (96a2298 2018-10-04) and passes on: rustdoc 1.31.0-nightly (f99911a 2018-10-23) Fix rust-lang#54478
Configuration menu - View commit details
-
Copy full SHA for b3e57db - Browse repository at this point
Copy the full SHA b3e57dbView commit details -
Rollup merge of rust-lang#55328 - raphlinus:copysign_typo, r=joshtrip…
…lett Fix doc for new copysign functions Thanks to @LukasKalbertodt for catching this. Addresses a comment raised in rust-lang#55169 after it was merged.
Configuration menu - View commit details
-
Copy full SHA for 401ee42 - Browse repository at this point
Copy the full SHA 401ee42View commit details -
Rollup merge of rust-lang#55340 - RalfJung:operand-docs, r=oli-obk
Operands no longer appear in places Fix an outdated comment.
Configuration menu - View commit details
-
Copy full SHA for 83906ec - Browse repository at this point
Copy the full SHA 83906ecView commit details -
Rollup merge of rust-lang#55345 - RalfJung:no-null, r=oli-obk
Remove is_null It was confusingly named (`is_zero` would have been better, as someone pointed out somewhere but I forgot who or where), and it didn't even reliably test for "is this value 0 at run-time" because out-of-bounds pointers *can* be 0. It's not used in rustc, and miri only really needs `is_null_ptr` and `to_bytes() == 0`, so let's just kill this method. r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 5443f7b - Browse repository at this point
Copy the full SHA 5443f7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a39bc4 - Browse repository at this point
Copy the full SHA 7a39bc4View commit details -
Rollup merge of rust-lang#55348 - pietroalbini:backport-stable-notes,…
… r=pietroalbini Backports the release notes update from stable to master. r? @ghost
Configuration menu - View commit details
-
Copy full SHA for ea5aad6 - Browse repository at this point
Copy the full SHA ea5aad6View commit details