Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 22 pull requests #55347

Merged
merged 66 commits into from
Oct 25, 2018
Merged

Rollup of 22 pull requests #55347

merged 66 commits into from
Oct 25, 2018

Commits on Sep 3, 2018

  1. Flesh out struct keyword docs

    The whole keyword docs thing is pretty new in Rust's history and needs
    some work before it's a shining gem. Here's hoping I can provide that.
    
    I basically shoved in a bunch of the most important information from the
    reference and the book, along with leaving links to both at the end. I
    don't think keyword docs need to have complete detail, just all the
    broad strokes, so if someone's confused about a usage of a keyword they
    can look at the std documentation for that keyword.
    iirelu committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    047aac5 View commit details
    Browse the repository at this point in the history
  2. Add docs for as keyword

    It's pretty basic and could do with more details, but it's a good
    starter until someone else improves it.
    iirelu committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    1142bbd View commit details
    Browse the repository at this point in the history
  3. Add keyword docs on const

    Turns out writing docs on keywords that are used in multiple different
    places in entirely different contexts gets a little harder. I put a
    footnote on `*const` syntax just to make sure you can find it if need
    be, but it might need more detail.
    iirelu committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    c1bd8a9 View commit details
    Browse the repository at this point in the history
  4. Fix a few small things, re-word others

    Mostly addressing notes on ambiguous syntax and spurious newlines.
    iirelu committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    6cbcfa2 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Add docs for crate keyword

    I think it might be used in some other things, but I'm not fluent enough
    at sifting through the rust compiler's source code to find every use of
    a specific keyword.
    
    This leaves the question of how to document the `extern` keyword, what
    with how much overlap it has with `crate`, but that's used with ABI
    stuff so that should be fine.
    iirelu committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    f8d6261 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2018

  1. Add keyword docs on enum

    iirelu committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f15a1ec View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2018

  1. Add docs on extern keyword

    iirelu committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    f91ad44 View commit details
    Browse the repository at this point in the history
  2. Expand fn keyword docs

    iirelu committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    a5c4a38 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. Document for keyword

    iirelu committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    f7a6638 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Document if keyword.

    iirelu committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    5d05ae7 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. Configuration menu
    Copy the full SHA
    5393b27 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Document impl keyword

    This commit also splits out linky-line-thingies into two lines, which
    judging from the source code for tidy, should be enough to make it shut
    up and accept me for who I am, dammit.
    iirelu committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    738e58d View commit details
    Browse the repository at this point in the history
  2. Rework let keyword docs

    It didn't strictly need to be reworked and I'm not sure my version is
    better, but oh well, I'm doing it for consistency.
    iirelu committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    165690b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2018

  1. Add keyword docs for loop.

    iirelu committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    76a353b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2018

  1. Removed dead links to unwritten keyword docs

    Most of these will eventually be filled, but right now travis-ci enjoys
    complaining about the fact that there's links that lead nowhere, so
    they're gone. Hopefully someone remembers to re-add them later.
    iirelu committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    50f631c View commit details
    Browse the repository at this point in the history
  2. Incorporate criticisms into keyword docs

    Thanks to @Centril for these.
    iirelu committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    577dbc8 View commit details
    Browse the repository at this point in the history
  3. Remove the last broken link.

    Dangit. I really thought I got them all.
    iirelu committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    619dfeb View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. update tcp stream documentation

    Charles Hathaway committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    c514b62 View commit details
    Browse the repository at this point in the history
  2. Accept Option<Box<$t:ty>> in macro argument

    Given the following code, compile successfuly:
    
    ```
    macro_rules! test {
        (
            fn fun() -> Option<Box<$t:ty>>;
        ) => {
            fn fun(x: $t) -> Option<Box<$t>>
            { Some(Box::new(x)) }
        }
    }
    
    test! {
        fn fun() -> Option<Box<i32>>;
    }
    ```
    estebank committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    c77a0cf View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Small changes to fix documentation auto compile issues

    Charles Hathaway committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    4530b8c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. Configuration menu
    Copy the full SHA
    f8550a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a70ef6a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. in which unused-parens suggestions heed what the user actually wrote

    Aaron Hill pointed out that unnecessary parens around a macro call
    (paradigmatically, `format!`) yielded a suggestion of hideous
    macro-expanded code. (The slightly unusual choice of using the
    pretty-printer to compose suggestions was quite recently commented on
    in the commit message for 1081bbb ("abolish ICE when pretty-printing
    async block"), but without any grounds to condemn it as a 𝘣𝘢𝘥
    choice. Hill's report provides the grounds.) `span_to_snippet` is
    fallable as far as the type system is concerned (because, who knows,
    macros or something), so the pretty-printing can live on in the
    oft-neglected `else` branch.
    
    Resolves rust-lang#55109.
    zackmdavis committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    475be10 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. submodules: update clippy from 5afdf8b to b1d0343

    Changes:
    ````
    new_ret_no_self: add sample from rust-lang#3313 to Known Problems section.
    Support multiline comments and hopefully fix panic
    Check for comments in collapsible ifs
    Resolve ICE in needless range loop lint
    RIIR update_lints: Update changelog links
    Rename if_let_redundant_pattern_matching to redundant_pattern_matching
    Add lint for redundant pattern matching for explicit return boolean
    Fix issue rust-lang#3322: reword help message for len_zero
    Simplify manual_memcpy suggestion in some cases
    Fix dogfood
    Update known problems for unnecessary_fold
    RIIR update_lints: Replace lint count in README.md
    Rename `active_lints` to `usable_lints`
    Add comment on WalkDir vs. fs::read_dir
    sort_by -> sort_by_key
    Some more documentation for clippy_dev
    Use `WalkDir` to also gather from subdirectories
    Avoid linting `boxed_local` on trait implementations.
    Website: Make lint categories linkable
    Restore clippy_dummy's placeholder name
    Swap order of methods in `needless_range_loop` suggestion in some cases
    Revert "Exclude pattern guards from unnecessary_fold lint"
    Exclude pattern guards from unnecessary_fold lint
    ````
    matthiaskrgr committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    9378705 View commit details
    Browse the repository at this point in the history
  2. Clarified code example

    The example was not as clear as it could be because it was making an assumption about the structure of the data in order to multiply the number of collection elements by the item size. This change demonstrates the idea more straightforwardly, without the calculation.
    peterjoel authored Oct 21, 2018
    Configuration menu
    Copy the full SHA
    0f6e274 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f70096 View commit details
    Browse the repository at this point in the history
  4. only issue "variant of the expected type" suggestion for enums

    Felix S. Klock II pointed out that this suggestion (introduced in
    pull-request rust-lang#43178 / eac7410) was being issued for one-field-struct
    expected types (in which case it is misleading and outright wrong),
    even though it was only intended for one-field enum-variants (most
    notably, `Some`). Particularly tender-hearted code-historians may be
    inclined to show mercy towards the author of rust-lang#43178 on the grounds
    that it's somewhat confusing that struct field definitions are given
    in a type called `ty::VariantDef`.
    
    Add a conditional to adhere to the original intent. (It would be
    possible to generalize to structs, but not obviously net desirable.)
    This adds a level of indentation, so the diff here is going to be
    easier to read in ignore-whitespace mode (`-w`).
    
    Resolves rust-lang#55250.
    zackmdavis committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    b0d3d3b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c675111 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. Suggest appropriate syntax on missing lifetime specifier in return type

    Suggest using `'static` when a lifetime is missing in the return type
    with a structured suggestion instead of a note.
    estebank committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    e1e52eb View commit details
    Browse the repository at this point in the history
  2. review comments

    estebank committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    d0bd69a View commit details
    Browse the repository at this point in the history
  3. [review comments] modify test and clean up code

    Co-Authored-By: estebank <esteban@kuber.com.ar>
    oli-obk and estebank committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    dd91c8f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. Remove redundant clone

    sinkuu committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    fda3326 View commit details
    Browse the repository at this point in the history
  2. Do some copy editing on the release notes

    I was reading through the release notes to find something and noticed
    some small grammatical and consistency issues.
    carols10cents committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    8d6ee8f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4972bea View commit details
    Browse the repository at this point in the history
  4. Update stdsimd submodule

    Fixes a SSE2 bug.
    kazcw committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    3d9231c View commit details
    Browse the repository at this point in the history
  5. Hopefully fix compile error

    This was added in the fortnight this PR spent stale. I'm hoping this
    one-liner fixes it.
    iirelu committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    320ec81 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3539132 View commit details
    Browse the repository at this point in the history
  7. Set RUST_BACKTRACE=0 for rustdoc-ui/failed-doctest-output.rs

    This UI test is sensitive to backtrace output, so it should make sure
    that backtraces are not enabled by the environment.
    cuviper committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    f2443a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2018

  1. This is a regression test for rust-lang#54478.

    I confirmed that it fails on:
    rustdoc 1.30.0-beta.12 (96a2298 2018-10-04)
    and passes on:
    rustdoc 1.31.0-nightly (f99911a 2018-10-23)
    pnkfelix committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    be2075c View commit details
    Browse the repository at this point in the history
  2. Documents From implementations for Stdio

    Add a basic summary and an example to From `ChildStdin`, `ChildStdout`,
    `ChildStderr`, `File` implementations.
    octronics committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    0b82e03 View commit details
    Browse the repository at this point in the history
  3. Fix doc for new copysign functions

    Thanks to @LukasKalbertodt for catching this. Addresses a comment
    raised in rust-lang#55169 after it was merged.
    raphlinus committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    538f65e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Configuration menu
    Copy the full SHA
    431b254 View commit details
    Browse the repository at this point in the history
  2. Remove is_null

    It was confusingly named (`is_zero` would have been better), and it didn't even
    reliably test for "is this value 0 at run-time" because out-of-bounds pointers
    *can* be 0.
    RalfJung committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    cbe6b22 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#53507 - phungleson:fix-impl-from-for-waker,…

    … r=cramertj
    
    Add doc for impl From for Waker
    
    As part of issue rust-lang#51430 (cc @skade).
    
    The impl is very simple, so not sure if we need to go into any details.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    18f7d41 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#53931 - iirelu:keyword-docs, r=steveklabnik

    Gradually expanding libstd's keyword documentation
    
    I'm working on adding new keywords to the documentation and refreshing the incomplete older ones, and I'm hoping that I can eventually add all the standalone-usable keywords after a bunch of incremental work. It would be cool to see the keywords section of std's docs be a definitive reference as to what each keyword means when you see it, and that's what I'm aiming towards with this work.
    
    I'm far from a Rust expert so there will inevitably be things to fix in this, also I'm not sure if this should be a bunch of quickly-merged PRs or one gradually-updated PR that gets merged once it's done.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    3bcfa07 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#54965 - chathaway-codes:update-tcp-stream-d…

    …ocs, r=GuillaumeGomez
    
    update tcp stream documentation
    
    A small styling issue that seemed inconsistent here when compared to other places (such as https://doc.rust-lang.org/beta/std/net/struct.TcpListener.html).
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    699f591 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#54977 - estebank:macro-arg-parse, r=pnkfelix

    Accept `Option<Box<$t:ty>>` in macro argument
    
    Given the following code, compile successfuly:
    
    ```
    macro_rules! test {
        (
            fn fun() -> Option<Box<$t:ty>>;
        ) => {
            fn fun(x: $t) -> Option<Box<$t>>
            { Some(Box::new(x)) }
        }
    }
    
    test! {
        fn fun() -> Option<Box<i32>>;
    }
    ```
    
    Fix rust-lang#25274.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    f81e47f View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#55138 - zackmdavis:the_paren_trap, r=pnkfelix

    in which unused-parens suggestions heed what the user actually wrote
    
    Aaron Hill pointed out that unnecessary parens around a macro call (paradigmatically, `format!`) yielded a suggestion of hideous macro-expanded code. `span_to_snippet` is fallable as far as the type system is concerned, so the pretty-printing can live on in the oft-neglected `else` branch.
    
    Resolves rust-lang#55109.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    6dfeb76 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#55173 - estebank:suggest-static, r=oli-obk

    Suggest appropriate syntax on missing lifetime specifier in return type
    
    Suggest using `'static` when a lifetime is missing in the return type
    with a structured suggestion instead of a note.
    
    Fix rust-lang#55170.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    f50e285 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#55200 - octronics:gh51430, r=kennytm

    Documents `From` implementations for `Stdio`
    
    This PR solves part of rust-lang#51430 by adding a basic summary and an example to each `impl From` inside `process` module (`ChildStdin`, `ChildStdout`, `ChildStderr`, `File`).
    
    It does not document if the conversions allocate memory and how expensive they are.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    49eb443 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#55245 - matthiaskrgr:clippy, r=nikomatsakis

    submodules: update clippy from 5afdf8b to b1d0343
    
    Just a routine update.
    
    Changes:
    ````
    new_ret_no_self: add sample from rust-lang#3313 to Known Problems section.
    Support multiline comments and hopefully fix panic
    Check for comments in collapsible ifs
    Resolve ICE in needless range loop lint
    RIIR update_lints: Update changelog links
    Rename if_let_redundant_pattern_matching to redundant_pattern_matching
    Add lint for redundant pattern matching for explicit return boolean
    Fix issue rust-lang#3322: reword help message for len_zero
    Simplify manual_memcpy suggestion in some cases
    Fix dogfood
    Update known problems for unnecessary_fold
    RIIR update_lints: Replace lint count in README.md
    Rename `active_lints` to `usable_lints`
    Add comment on WalkDir vs. fs::read_dir
    sort_by -> sort_by_key
    Some more documentation for clippy_dev
    Use `WalkDir` to also gather from subdirectories
    Avoid linting `boxed_local` on trait implementations.
    Website: Make lint categories linkable
    Restore clippy_dummy's placeholder name
    Swap order of methods in `needless_range_loop` suggestion in some cases
    Revert "Exclude pattern guards from unnecessary_fold lint"
    Exclude pattern guards from unnecessary_fold lint
    ````
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    c4e51a2 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#55247 - peterjoel:peterjoel-prim-char-doc-e…

    …xample, r=joshtriplett
    
    Clarified code example in char primitive doc
    
    The example was not as clear as it could be because it was making an assumption about the structure of the data in order to multiply the number of elements in the slice by the item size. This change demonstrates the idea more straightforwardly, without needing a calculation, by just comparing the size of the slices.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    f740b8a View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#55251 - NieDzejkob:master, r=TimNN

    Fix a typo in the documentation of RangeInclusive
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    823244a View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#55253 - zackmdavis:some_suggestion, r=pnkfelix

    only issue "variant of the expected type" suggestion for enums
    
    This suggestion (introduced in pull-request rust-lang#43178 / eac7410) was being issued for one-field-struct expected types (in which case it is misleading and outright wrong), even though it was only intended for one-field enum-variants (most notably, `Some`).
    
    Add a conditional to adhere to the original intent. (It would be possible to generalize to structs, but not obviously net desirable.) This adds a level of indentation, so the diff here is going to be
    easier to read in [ignore-whitespace mode](rust-lang@b0d3d3b9?w=1).
    
    Resolves rust-lang#55250.
    
    r? @pnkfelix
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    f46ee04 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#55254 - rust-lang:clean-two-dots, r=Guillau…

    …meGomez
    
    Correct trailing ellipsis in name_from_pat
    
    r? @GuillaumeGomez
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    88341a9 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#55269 - matthiaskrgr:typos_oct, r=zackmdavis

    fix typos in various places
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    4f14bfd View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#55282 - sinkuu:redundant_clone, r=estebank

    Remove redundant clone
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    555df0f View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#55285 - integer32llc:release-notes-improvem…

    …ents, r=Aaronepower
    
    Do some copy editing on the release notes
    
    I was reading through the release notes to find something and noticed
    some small grammatical and consistency issues.
    
    I'm happy to revert any of these changes if folks disagree with them!
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    539ee06 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#55291 - kazcw:master, r=nikomatsakis

    Update stdsimd submodule
    
    Fixes a SSE2 bug. (rust-lang#55249)
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    c4723b3 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#55296 - cuviper:rustdoc-ui-backtrace, r=nik…

    …omatsakis
    
    Set RUST_BACKTRACE=0 for rustdoc-ui/failed-doctest-output.rs
    
    This UI test is sensitive to backtrace output, so it should make sure
    that backtraces are not enabled by the environment.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    1220e13 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#55306 - pnkfelix:issue-54478-regression-tes…

    …t-jemalloc-ctl, r=nikomatsakis
    
    Regression test for rust-lang#54478.
    
    This is a regression test for rust-lang#54478.
    
    I confirmed that it fails on:
    rustdoc 1.30.0-beta.12 (96a2298 2018-10-04)
    and passes on:
    rustdoc 1.31.0-nightly (f99911a 2018-10-23)
    
    Fix rust-lang#54478
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    b3e57db View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#55328 - raphlinus:copysign_typo, r=joshtrip…

    …lett
    
    Fix doc for new copysign functions
    
    Thanks to @LukasKalbertodt for catching this. Addresses a comment raised in rust-lang#55169 after it was merged.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    401ee42 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#55340 - RalfJung:operand-docs, r=oli-obk

    Operands no longer appear in places
    
    Fix an outdated comment.
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    83906ec View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#55345 - RalfJung:no-null, r=oli-obk

    Remove is_null
    
    It was confusingly named (`is_zero` would have been better, as someone pointed out somewhere but I forgot who or where), and it didn't even reliably test for "is this value 0 at run-time" because out-of-bounds pointers *can* be 0.
    
    It's not used in rustc, and miri only really needs `is_null_ptr` and `to_bytes() == 0`, so let's just kill this method.
    
    r? @oli-obk
    pietroalbini authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    5443f7b View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    7a39bc4 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#55348 - pietroalbini:backport-stable-notes,…

    … r=pietroalbini
    
    Backports the release notes update from stable to master.
    
    r? @ghost
    pietroalbini committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    ea5aad6 View commit details
    Browse the repository at this point in the history