Include bounds in generic re-ordering diagnostic #59572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
varkor
approved these changes
Mar 30, 2019
This commit extends the existing generic re-ordering diagnostic to include any bounds on the generic parameter, thus producing correct suggestions.
This commit updates the generic parameter re-ordering diagnostic to only mention const generics if the feature is enabled.
|
📌 Commit 0270d56 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0270d56 with merge 0dccd9284b4f68a54b6683dd90d687dc4cc1f750... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 31, 2019
Include bounds in generic re-ordering diagnostic Fixes rust-lang#59508. r? @estebank cc @varkor
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 31, 2019
Include bounds in generic re-ordering diagnostic Fixes rust-lang#59508. r? @estebank cc @varkor
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 31, 2019
Include bounds in generic re-ordering diagnostic Fixes rust-lang#59508. r? @estebank cc @varkor
bors
added a commit
that referenced
this pull request
Mar 31, 2019
Rollup of 4 pull requests Successful merges: - #58828 (libstd: deny(elided_lifetimes_in_paths)) - #59234 (Mention `no merge policy` in the CONTRIBUTING guide) - #59572 (Include bounds in generic re-ordering diagnostic) - #59574 (Distinguish message for external macros depending on error level) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59508.
r? @estebank
cc @varkor