Rollup of 4 pull requests #59584
Merged
Rollup of 4 pull requests #59584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary comment
This commit extends the existing generic re-ordering diagnostic to include any bounds on the generic parameter, thus producing correct suggestions.
This commit updates the generic parameter re-ordering diagnostic to only mention const generics if the feature is enabled.
…ths-libstd, r=oli-obk libstd: deny(elided_lifetimes_in_paths) r? @oli-obk
…i-obk Mention `no merge policy` in the CONTRIBUTING guide Issue: rust-lang#59233
Include bounds in generic re-ordering diagnostic Fixes rust-lang#59508. r? @estebank cc @varkor
…ing, r=Centril Distinguish message for external macros depending on error level fixes rust-lang#57716 (I picked you because assigned to this issue.) r? @estebank
|
@bors r+ p=4 |
|
📌 Commit fb8396d has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 31, 2019
Rollup of 4 pull requests Successful merges: - #58828 (libstd: deny(elided_lifetimes_in_paths)) - #59234 (Mention `no merge policy` in the CONTRIBUTING guide) - #59572 (Include bounds in generic re-ordering diagnostic) - #59574 (Distinguish message for external macros depending on error level) Failed merges: r? @ghost
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
no merge policyin the CONTRIBUTING guide #59234 (Mentionno merge policyin the CONTRIBUTING guide)Failed merges:
r? @ghost