Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish message for external macros depending on error level #59574

Merged
merged 1 commit into from
Mar 31, 2019

Conversation

JohnTitor
Copy link
Member

fixes #57716

(I picked you because assigned to this issue.)
r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2019
@Centril
Copy link
Contributor

Centril commented Mar 30, 2019

r? @Centril

Can you also squash the commits into one?
With that, r=me once travis is green.

@rust-highfive rust-highfive assigned Centril and unassigned estebank Mar 30, 2019
Remove unnecessary comment
@JohnTitor JohnTitor force-pushed the distinguish-error-vs-warning branch from bf4d502 to 45c82ab Compare March 30, 2019 22:54
@JohnTitor
Copy link
Member Author

@Centril Okay, I squashed the commits, thank you.

@Centril
Copy link
Contributor

Centril commented Mar 31, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 31, 2019

📌 Commit 45c82ab has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019
…ing, r=Centril

Distinguish message for external macros depending on error level

fixes rust-lang#57716

(I picked you because assigned to this issue.)
r? @estebank
@kennytm
Copy link
Member

kennytm commented Mar 31, 2019

@bors rollup-

Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019
…ing, r=Centril

Distinguish message for external macros depending on error level

fixes rust-lang#57716

(I picked you because assigned to this issue.)
r? @estebank
Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019
…ing, r=Centril

Distinguish message for external macros depending on error level

fixes rust-lang#57716

(I picked you because assigned to this issue.)
r? @estebank
Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019
…ing, r=Centril

Distinguish message for external macros depending on error level

fixes rust-lang#57716

(I picked you because assigned to this issue.)
r? @estebank
bors added a commit that referenced this pull request Mar 31, 2019
Rollup of 4 pull requests

Successful merges:

 - #58828 (libstd: deny(elided_lifetimes_in_paths))
 - #59234 (Mention `no merge policy` in the CONTRIBUTING guide)
 - #59572 (Include bounds in generic re-ordering diagnostic)
 - #59574 (Distinguish message for external macros depending on error level)

Failed merges:

r? @ghost
@bors bors merged commit 45c82ab into rust-lang:master Mar 31, 2019
@JohnTitor JohnTitor deleted the distinguish-error-vs-warning branch March 31, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish between error vs. warning for external macros
6 participants