Rollup of 8 pull requests #67853

Centril · 2020-01-04T01:19:57Z

Successful merges:

Suggest calling method when first argument is self #66913 (Suggest calling method when first argument is self)
no longer promote non-pattern const functions #67531 (no longer promote non-pattern const functions)
Add a test for #37333 #67773 (Add a test for [goal] modifying private method in another crate's impl should not require users of public methods to recompile #37333)
Nix reexports from rustc_span in syntax #67786 (Nix reexports from rustc_span in syntax)
Cleanup linkchecker whitelist #67789 (Cleanup linkchecker whitelist)
Implement uncommon_codepoints lint. #67810 (Implement uncommon_codepoints lint.)
tweak wording of mismatched delimiter errors #67835 (tweak wording of mismatched delimiter errors)
Also remove const-hack for abs #67845 (Also remove const-hack for abs)

Failed merges:

The test checks that we reuse the CGU of a crate when the implementation details of an `extern crate` have changed. Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>

linkchecker is no longer run on the compiler docs so they can be removed from the whitelist.

Suggest calling method when first argument is `self` Closes: rust-lang#66782 I've explored different approaches for this MR but I think the most straightforward is the best one. I've tried to find out if the methods for given type exist (to maybe have a better suggestion), but we don't collect them anywhere and collecting them is quite problematic. Moreover, collecting all the methods would require rewriting big part of the code and also could potentially include performance degradation, which I don't think is necessary for this simple case.

@eddyb

…akis no longer promote non-pattern const functions This is trying to pack-pedal a bit on promotion feature creep, as proposed by @eddyb [here](rust-lang/const-eval#19 (comment)): possibly, a sane subset of `const fn` that we could promote are those that are just constructors -- the same subset that we might want to allow in pattern position at some point. So, this removes the `rustc_promotable` attribute from the three functions they identified that do not fit this pattern. The first step is to run crater to see if there is code in the wild that relies on this being promotable. r? @oli-obk

…sakis Add a test for rust-lang#37333 The test checks that we reuse the CGU of a crate when the implementation details of an `extern crate` have changed. Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>

@petrochenkov

Nix reexports from `rustc_span` in `syntax` Remove reexports `syntax::{source_map, symbol, edition}` and use `rustc_span` paths directly. r? @petrochenkov

…komatsakis Cleanup linkchecker whitelist linkchecker is no longer run on the compiler docs so they can be removed from the whitelist.

…r=Manishearth Implement uncommon_codepoints lint. Part of rust-lang#55467 . The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.

@estebank

tweak wording of mismatched delimiter errors This PR improves the wording of the "incorrect delimiter" error messages. Here's a quick rationale: - *"un-closed" -> "unclosed"*: "unclosed" is valid English, so there's no need to hyphenate the prefix. This should be pretty uncontroversial, I think. - *"close delimiter" -> "closing delimiter"*: In my anecdotal experience, I've always heard "closing delimiter" or "closing parenthesis". In addition, the codebase already uses this terminology in comments and function names more than "close delimiter", which could indicate that it's more intuitive. - "incorrect delimiter" -> "mismatched delimiter": "Incorrect delimiter" is vague; why is it incorrect? "mismatched" clearly indicates why the delimiter is causing the error. r? @estebank

@oli-obk

…i-obk Also remove const-hack for abs Closes rust-lang#67842. r? @oli-obk

Centril · 2020-01-04T01:20:21Z

@bors r+ p=8 rollup=never

bors · 2020-01-04T01:20:22Z

📌 Commit 745f771 has been approved by Centril

bors · 2020-01-04T06:20:15Z

⌛ Testing commit 745f771 with merge abf2e00...

@ghost

Rollup of 8 pull requests Successful merges: - #66913 (Suggest calling method when first argument is `self`) - #67531 (no longer promote non-pattern const functions) - #67773 (Add a test for #37333) - #67786 (Nix reexports from `rustc_span` in `syntax`) - #67789 (Cleanup linkchecker whitelist) - #67810 (Implement uncommon_codepoints lint.) - #67835 (tweak wording of mismatched delimiter errors) - #67845 (Also remove const-hack for abs) Failed merges: r? @ghost

rust-highfive · 2020-01-04T06:32:36Z

The job i686-mingw-1 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-04T02:36:40.9462925Z do so (now or later) by using -b with the checkout command again. Example:
2020-01-04T02:36:40.9463305Z 
2020-01-04T02:36:40.9463493Z   git checkout -b <new-branch-name>
2020-01-04T02:36:40.9463630Z 
2020-01-04T02:36:40.9463773Z HEAD is now at b23243dfe Auto merge of #67853 - Centril:rollup-sx5zi9n, r=Centril
2020-01-04T02:36:40.9841919Z ##[section]Starting: Setup environment
2020-01-04T02:36:40.9953792Z ==============================================================================
2020-01-04T02:36:40.9953890Z Task         : Bash
2020-01-04T02:36:40.9953959Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2020-01-04T04:35:33.6919651Z 
2020-01-04T04:35:33.6920279Z 
2020-01-04T04:35:33.7676341Z failed to run: D:\a\1\s\build\bootstrap\debug\bootstrap test --exclude src/test/ui --exclude src/test/compile-fail
2020-01-04T04:35:33.7677086Z Build completed unsuccessfully in 1:48:34
2020-01-04T04:35:33.8233806Z make: *** [Makefile:89: ci-mingw-subset-1] Error 1
2020-01-04T04:35:33.9022986Z   local time: Sat Jan  4 04:35:33 CUT 2020
2020-01-04T04:35:34.3098838Z   network time: Sat, 04 Jan 2020 04:35:34 GMT
2020-01-04T04:35:34.3101742Z == end clock drift check ==
2020-01-04T04:35:34.3834320Z 
2020-01-04T04:35:34.3834320Z 
2020-01-04T04:35:34.7746249Z ##[error]Bash exited with code '2'.
2020-01-04T04:35:34.8121976Z ##[section]Starting: Checkout
2020-01-04T04:35:34.9044403Z ==============================================================================
2020-01-04T04:35:34.9044563Z Task         : Get sources
2020-01-04T04:35:34.9044653Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-01-04T09:32:24Z

☀️ Test successful - checks-azure
Approved by: Centril
Pushing abf2e00 to master...

rust-highfive · 2020-01-04T09:33:55Z

📣 Toolstate changed by #67853!

Tested on commit abf2e00.
Direct link to PR: #67853

💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).

@mcarton

Tested on commit rust-lang/rust@abf2e00. Direct link to PR: <rust-lang/rust#67853> 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra). 💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).

Specifically caused by rust-lang/rust#67786

Rustup to rust-lang/rust#67853 Specifically caused by rust-lang/rust#67786 changelog: none

Changes: ```` rustup rust-lang#67853 deps: update clippy Update Clippy Update cargo. Correct two links to the json-error-emitter ```` Fixes rust-lang#67708

RalfJung and others added 25 commits December 22, 2019 18:37

no longer promote non-pattern const functions

368ac73

Suggest calling method when first argument is self

8d189ed

Add more detailed suggestion

8e5b2c8

Add arguments to suggestion method call

0918539

Extend suggestion span to whole method call

7353afd

Extract checking for self arg to separate method

2168c0b

Simplify match expr

7b91ef8

Add a test for rust-lang#37333

cfab634

The test checks that we reuse the CGU of a crate when the implementation details of an `extern crate` have changed. Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>

Cleanup linkchecker whitelist

23f5431

linkchecker is no longer run on the compiler docs so they can be removed from the whitelist.

Normalize syntax::source_map imports.

75e4783

Normalize syntax::symbol imports.

4ff12ce

Normalize syntax::edition imports.

b1aad76

syntax::map_in_place: leave fixme

bebdb44

fix src/test fallout

6e4ea14

Implement uncommon_codepoints lint.

485e98a

tweak wording of mismatched delimiter errors

7fd014d

Also remove const-hack for abs

ae002c1

Rollup merge of rust-lang#67786 - Centril:canon-span, r=petrochenkov

814e3af

Nix reexports from `rustc_span` in `syntax` Remove reexports `syntax::{source_map, symbol, edition}` and use `rustc_span` paths directly. r? @petrochenkov

Rollup merge of rust-lang#67789 - ollie27:linkchecker_whitelist, r=ni…

e72a214

…komatsakis Cleanup linkchecker whitelist linkchecker is no longer run on the compiler docs so they can be removed from the whitelist.

Rollup merge of rust-lang#67810 - crlf0710:uncommon_codepoints_lint, …

b32dc91

…r=Manishearth Implement uncommon_codepoints lint. Part of rust-lang#55467 . The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.

Rollup merge of rust-lang#67845 - jumbatm:also-unconst-hack-abs, r=ol…

745f771

…i-obk Also remove const-hack for abs Closes rust-lang#67842. r? @oli-obk

Centril added the rollup A PR which is a rollup label Jan 4, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 4, 2020

Centril mentioned this pull request Jan 4, 2020

no longer promote non-pattern const functions #67531

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2020

bors merged commit 745f771 into rust-lang:master Jan 4, 2020

bors mentioned this pull request Jan 4, 2020

buffer lexer errors in rustdoc syntax checking #67563

Merged

rust-highfive mentioned this pull request Jan 4, 2020

clippy-driver no longer builds after rust-lang/rust#67853 #67859

Closed

bors mentioned this pull request Jan 4, 2020

Region naming refactoring [6/N] #67476

Merged

rust-highfive mentioned this pull request Jan 4, 2020

miri no longer builds after rust-lang/rust#67853 #67860

Closed

phansch added a commit to phansch/rust-clippy that referenced this pull request Jan 4, 2020

Rustup to rust-lang/rust#67853

14a1752

Specifically caused by rust-lang/rust#67786

phansch added a commit to phansch/rust-clippy that referenced this pull request Jan 4, 2020

Rustup to rust-lang/rust#67853

c5178e8

Specifically caused by rust-lang/rust#67786

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jan 4, 2020

Auto merge of #4992 - phansch:rustup_foobar, r=matthiaskrgr

05b4603

Rustup to rust-lang/rust#67853 Specifically caused by rust-lang/rust#67786 changelog: none

Centril deleted the rollup-sx5zi9n branch January 4, 2020 15:31

matthiaskrgr added a commit to matthiaskrgr/rls that referenced this pull request Jan 4, 2020

rustup rust-lang/rust#67853

5cc3183

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #67853

Rollup of 8 pull requests #67853

Centril commented Jan 4, 2020

Centril commented Jan 4, 2020

bors commented Jan 4, 2020

bors commented Jan 4, 2020

rust-highfive commented Jan 4, 2020

bors commented Jan 4, 2020

rust-highfive commented Jan 4, 2020

Rollup of 8 pull requests #67853

Rollup of 8 pull requests #67853

Conversation

Centril commented Jan 4, 2020

Centril commented Jan 4, 2020

bors commented Jan 4, 2020

bors commented Jan 4, 2020

rust-highfive commented Jan 4, 2020

bors commented Jan 4, 2020

rust-highfive commented Jan 4, 2020