Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove liballoc unneeded explicit link #74185

Merged
merged 3 commits into from
Aug 15, 2020
Merged

Remove liballoc unneeded explicit link #74185

merged 3 commits into from
Aug 15, 2020

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Jul 9, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2020
@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 9, 2020

📌 Commit 86d182ebd0cf9900f32e1f58addc1fc21f9b791b has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2020
@lcnr
Copy link
Contributor

lcnr commented Jul 9, 2020

Doesn't this break because Vec is reexported in std?

@lcnr
Copy link
Contributor

lcnr commented Jul 9, 2020 •
edited
Loading

See #65983, this is a fairly frequent issue, also see #73579

@jonas-schievink
Copy link
Contributor

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2020
@jonas-schievink
Copy link
Contributor

I thought we had a link checker to catch broken doc links

@lcnr
Copy link
Contributor

lcnr commented Jul 9, 2020

hmm, maybe because these links aren't broken? 🤔 they just aren't interpreted as links at all

@jonas-schievink
Copy link
Contributor

Oh, yeah

@pickfire
Copy link
Contributor Author

pickfire commented Jul 10, 2020 •
edited
Loading

I have them at a separate experimental crate I am working on https://github.com/pickfire/ve, but there is no issue removing it (not the other links), it is not counted as a dead link, I didn't build the one in std.

I thought we had a link checker to catch broken doc links

Don't cargo doc have them?

@jyn514
Copy link
Member

jyn514 commented Jul 17, 2020

Doesn't this break because Vec is reexported in std?

#73101 just landed so this should be fixed after a rebase! You'll need to build with x.py doc --stage 1 to get the most recent fixes.

@jyn514 jyn514 mentioned this pull request Jul 17, 2020
Merged
@pickfire
Copy link
Contributor Author

You'll need to build with x.py doc --stage 1 to get the most recent fixes.

I don't understand what I need to do for that.

@pickfire
Copy link
Contributor Author

@jyn514 ping, what can I do?

jyn514
jyn514 reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more nits since we're cleaning things up anyway. Other than that this looks great :)

src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Outdated Show resolved Hide resolved
pickfire
pickfire commented Jul 24, 2020
View reviewed changes
src/liballoc/vec.rs Outdated Show resolved Hide resolved
@pickfire
Copy link
Contributor Author

Later when I get back to working on ve, then I would try to check if more docs link can be cleaned up.

@jyn514
Copy link
Member

jyn514 commented Jul 24, 2020

Ah right associated items don't work yet, this is #74489. r=me once CI is fixed.

error: `[Vec::into_iter]` cannot be resolved, ignoring it.
    --> src/liballoc/vec.rs:2587:34
     |
2587 | /// This `struct` is created by [`Vec::into_iter`] (provided by the
     |                                  ^^^^^^^^^^^^^^^^ cannot be resolved, ignoring

@bors
Copy link
Contributor

bors commented Jul 28, 2020

☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts.

@Muirrum
Copy link
Member

Muirrum commented Aug 13, 2020

@pickfire What's the status of this PR? There are outstanding merge conflicts.

@jyn514 jyn514 added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Aug 13, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 13, 2020

The Vec::into_iter change needs to reverted, other than that this is good to go.

@pickfire
Copy link
Contributor Author

@Muirrum Thanks for the ping. @jyn514 shared something which I don't saw last time, I don't know what to do back then.

@jyn514
Copy link
Member

jyn514 commented Aug 14, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 14, 2020

📌 Commit d2ecfcf has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2020
@tmandry tmandry mentioned this pull request Aug 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2020
@bors
Auto merge of rust-lang#75538 - tmandry:rollup-i8miv8q, r=tmandry
95879ad 
Rollup of 17 pull requests

Successful merges:

 - rust-lang#73943 (Document the unsafe keyword)
 - rust-lang#74062 (deny(unsafe_op_in_unsafe_fn) in libstd/ffi/c_str.rs)
 - rust-lang#74185 (Remove liballoc unneeded explicit link)
 - rust-lang#74192 (Improve documentation on process::Child.std* fields)
 - rust-lang#74409 (Change Debug impl of SocketAddr and IpAddr to match their Display output)
 - rust-lang#75195 (BTreeMap: purge innocent use of into_kv_mut)
 - rust-lang#75214 (Use intra-doc links in `mem::manually_drop` & `mem::maybe_uninit`)
 - rust-lang#75432 (Switch to intra-doc links in `std::process`)
 - rust-lang#75482 (Clean up E0752 explanation)
 - rust-lang#75501 (Move to intra doc links in std::ffi)
 - rust-lang#75509 (Tweak suggestion for `this` -> `self`)
 - rust-lang#75511 (Do not emit E0228 when it is implied by E0106)
 - rust-lang#75515 (Bump std's libc version to 0.2.74)
 - rust-lang#75517 (Promotion and const interning comments)
 - rust-lang#75519 (BTreeMap: refactor splitpoint and move testing over to unit test)
 - rust-lang#75530 (Switch to intra-doc links in os/raw/*.md)
 - rust-lang#75531 (Migrate unit tests of btree collections to their native breeding ground)

Failed merges:

r? @ghost
@bors bors merged commit 3111a8c into rust-lang:master Aug 15, 2020
@pickfire pickfire deleted the liballoc-iter-doc branch August 15, 2020 09:30
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
9 participants
@pickfire @rust-highfive @jonas-schievink @bors @lcnr @jyn514 @Muirrum @cuviper @nikomatsakis