Improve documentation on process::Child.std* fields #74192
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
src/libstd/process.rs
Outdated
| /// ``` | ||
| /// let stdin = child.stdin.take().unwrap(); | ||
| /// ``` | ||
| /// to avoid partially moving the `child` and thus block yourself from calling |
There was a problem hiding this comment.
| /// to avoid partially moving the `child` and thus block yourself from calling | |
| /// to avoid partially moving the `child` and thus blocking yourself from calling |
|
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnTitor
added
S-waiting-on-author
|
This has no response from the reviewer for a while. |
Mark-Simulacrum
force-pushed
the
patch-1
branch
from
bc1b930
to
a021b92
Compare
|
@bors r+ Applied suggestions and squashed. Thanks! |
|
📌 Commit a021b9219e0d2544374046289d9054947798231d has been approved by |
bors
added
S-waiting-on-bors
|
The doctests need to be marked with I'd also add a newline before the first fence. I'm not sure whether it affects the rendering, but it does seem to be the convention. |
|
@bors r- rollup=always —^ and it’s docs change only. |
bors
added
S-waiting-on-author
Mark-Simulacrum
force-pushed
the
patch-1
branch
from
a021b92
to
3d86296
Compare
As a relative beginner, it took a while for me to figure out I could just steal the references to avoid partially moving the child and thus retain ability to call functions on it (and store it in structs etc).
Mark-Simulacrum
force-pushed
the
patch-1
branch
from
3d86296
to
90e4c90
Compare
|
@bors r+ |
|
📌 Commit 90e4c90 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 17 pull requests Successful merges: - rust-lang#73943 (Document the unsafe keyword) - rust-lang#74062 (deny(unsafe_op_in_unsafe_fn) in libstd/ffi/c_str.rs) - rust-lang#74185 (Remove liballoc unneeded explicit link) - rust-lang#74192 (Improve documentation on process::Child.std* fields) - rust-lang#74409 (Change Debug impl of SocketAddr and IpAddr to match their Display output) - rust-lang#75195 (BTreeMap: purge innocent use of into_kv_mut) - rust-lang#75214 (Use intra-doc links in `mem::manually_drop` & `mem::maybe_uninit`) - rust-lang#75432 (Switch to intra-doc links in `std::process`) - rust-lang#75482 (Clean up E0752 explanation) - rust-lang#75501 (Move to intra doc links in std::ffi) - rust-lang#75509 (Tweak suggestion for `this` -> `self`) - rust-lang#75511 (Do not emit E0228 when it is implied by E0106) - rust-lang#75515 (Bump std's libc version to 0.2.74) - rust-lang#75517 (Promotion and const interning comments) - rust-lang#75519 (BTreeMap: refactor splitpoint and move testing over to unit test) - rust-lang#75530 (Switch to intra-doc links in os/raw/*.md) - rust-lang#75531 (Migrate unit tests of btree collections to their native breeding ground) Failed merges: r? @ghost
As a relative beginner, it took a while for me to figure out I could just steal the references to avoid partially moving the child and thus retain ability to call functions on it (and store it in structs etc).