Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to intra-doc links in std::process #75432

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Switch to intra-doc links in std::process #75432

merged 2 commits into from
Aug 15, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Aug 12, 2020

Part of #75080.

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2020
@camelid
Copy link
Member Author

camelid commented Aug 12, 2020

@rustbot modify labels to T-doc A-intra-doc-links T-rustdoc

@rustbot rustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 12, 2020
@camelid
Copy link
Member Author

camelid commented Aug 12, 2020

r? @jyn514

@rust-highfive rust-highfive assigned jyn514 and unassigned KodrAus Aug 12, 2020
camelid
camelid commented Aug 12, 2020
View reviewed changes
library/std/src/process.rs Outdated Show resolved Hide resolved
camelid
camelid commented Aug 12, 2020
View reviewed changes
library/std/src/process.rs Outdated Show resolved Hide resolved
camelid
camelid commented Aug 12, 2020
View reviewed changes
library/std/src/process.rs Outdated Show resolved Hide resolved
@camelid
Use Child::std{in,out,err} instead of Child.
d8f9614 
These links were broken before.
@jyn514 jyn514 mentioned this pull request Aug 12, 2020
Closed
@camelid
Copy link
Member Author

camelid commented Aug 14, 2020

@jyn514 Do you want me to ask @KodrAus to review this since rust-highfive assigned him at first?

@jyn514
Copy link
Member

jyn514 commented Aug 14, 2020

Whoops, missed that you addressed the comments.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 14, 2020

📌 Commit d8f9614 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2020
@camelid
Copy link
Member Author

camelid commented Aug 14, 2020

That's okay! Thanks for reviewing this!

@tmandry tmandry mentioned this pull request Aug 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2020
@bors
Auto merge of rust-lang#75538 - tmandry:rollup-i8miv8q, r=tmandry
95879ad 
Rollup of 17 pull requests

Successful merges:

 - rust-lang#73943 (Document the unsafe keyword)
 - rust-lang#74062 (deny(unsafe_op_in_unsafe_fn) in libstd/ffi/c_str.rs)
 - rust-lang#74185 (Remove liballoc unneeded explicit link)
 - rust-lang#74192 (Improve documentation on process::Child.std* fields)
 - rust-lang#74409 (Change Debug impl of SocketAddr and IpAddr to match their Display output)
 - rust-lang#75195 (BTreeMap: purge innocent use of into_kv_mut)
 - rust-lang#75214 (Use intra-doc links in `mem::manually_drop` & `mem::maybe_uninit`)
 - rust-lang#75432 (Switch to intra-doc links in `std::process`)
 - rust-lang#75482 (Clean up E0752 explanation)
 - rust-lang#75501 (Move to intra doc links in std::ffi)
 - rust-lang#75509 (Tweak suggestion for `this` -> `self`)
 - rust-lang#75511 (Do not emit E0228 when it is implied by E0106)
 - rust-lang#75515 (Bump std's libc version to 0.2.74)
 - rust-lang#75517 (Promotion and const interning comments)
 - rust-lang#75519 (BTreeMap: refactor splitpoint and move testing over to unit test)
 - rust-lang#75530 (Switch to intra-doc links in os/raw/*.md)
 - rust-lang#75531 (Migrate unit tests of btree collections to their native breeding ground)

Failed merges:

r? @ghost
@bors bors merged commit b026181 into rust-lang:master Aug 15, 2020
@jyn514 jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
7 participants
@camelid @rust-highfive @jyn514 @bors @cuviper @KodrAus @rustbot