-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #78623
Rollup of 6 pull requests #78623
Commits on Oct 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7a25123 - Browse repository at this point
Copy the full SHA 7a25123View commit details -
Add #[inline] to some core::str functions.
Almost all these functions already had #[inline]. These were missing.
Configuration menu - View commit details
-
Copy full SHA for 76daca2 - Browse repository at this point
Copy the full SHA 76daca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc850ec - Browse repository at this point
Copy the full SHA cc850ecView commit details
Commits on Oct 31, 2020
-
std::format and core::write macros' docs linked to core::fmt for format string reference, even though only std::fmt has format string documentation and the link titles were std::fmt.
Configuration menu - View commit details
-
Copy full SHA for 3baf6a4 - Browse repository at this point
Copy the full SHA 3baf6a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d417bbe - Browse repository at this point
Copy the full SHA d417bbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7652bc3 - Browse repository at this point
Copy the full SHA 7652bc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed96321 - Browse repository at this point
Copy the full SHA ed96321View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f630af - Browse repository at this point
Copy the full SHA 9f630afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 607076e - Browse repository at this point
Copy the full SHA 607076eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9749eb7 - Browse repository at this point
Copy the full SHA 9749eb7View commit details -
Apply suggestions from code review
Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
Configuration menu - View commit details
-
Copy full SHA for db416b2 - Browse repository at this point
Copy the full SHA db416b2View commit details
Commits on Nov 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e5b1f69 - Browse repository at this point
Copy the full SHA e5b1f69View commit details -
Rollup merge of rust-lang#78073 - fusion-engineering-forks:inline, r=…
…eddyb Add #[inline] to some functions in core::str. Almost all str functions already had #[inline].
Configuration menu - View commit details
-
Copy full SHA for 835310e - Browse repository at this point
Copy the full SHA 835310eView commit details -
Rollup merge of rust-lang#78596 - pavlukivan:master, r=m-ou-se
Fix doc links to std::fmt `std::format` and `core::write` macros' docs linked to `core::fmt` for format string reference, even though only `std::fmt` has format string documentation (and the link titles were `std::fmt`)
Configuration menu - View commit details
-
Copy full SHA for 25eac92 - Browse repository at this point
Copy the full SHA 25eac92View commit details -
Rollup merge of rust-lang#78599 - panstromek:master, r=m-ou-se
Add note to process::arg[s] that args shouldn't be escaped or quoted This came out of discussion on [forum](https://users.rust-lang.org/t/how-to-get-full-output-from-command/50626), where I recently asked a question and it turned out that the problem was redundant quotation: ```rust Command::new("rg") .arg("\"pattern\"") // this will look for "pattern" with quotes included ``` This is something that has bitten me few times already (in multiple languages actually), so It'd be grateful to have it in the docs, even though it's not sctrictly Rust specific problem. Other users also agreed. This can be really annoying to debug, because in many cases (inluding mine), quotes can be legal part of the argument, so the command doesn't fail, it just behaves unexpectedly. Not everybody (including me) knows that quotes around arguments are part of the shell and not part of the called program. Coincidentally, somoene had the same problem [yesterday](https://www.reddit.com/r/rust/comments/jkxelc/going_crazy_over_running_a_curl_process_from_rust/) on reddit. I am not a native speaker, so I welcome any corrections or better formulation, I don't expect this to be merged as is. I was also reminded that this is platform/shell specific behaviour, but I didn't find a good way to formulate that briefly, any ideas welcome. It's also my first PR here, so I am not sure I did everything correctly, I did this just from Github UI.
Configuration menu - View commit details
-
Copy full SHA for f281a76 - Browse repository at this point
Copy the full SHA f281a76View commit details -
Rollup merge of rust-lang#78602 - RalfJung:raw-ptr-aliasing-issues, r…
…=m-ou-se fix various aliasing issues in the standard library This fixes various cases where the standard library either used raw pointers after they were already invalidated by using the original reference again, or created raw pointers for one element of a slice and used it to access neighboring elements.
Configuration menu - View commit details
-
Copy full SHA for 8ed31d2 - Browse repository at this point
Copy the full SHA 8ed31d2View commit details -
Rollup merge of rust-lang#78603 - petrochenkov:fourdigits, r=matthewj…
…asper expand: Tweak a comment in implementation of `macro_rules` The answer to the removed FIXME is that we don't apply mark to the span `sp` just because that span is no longer used. We could apply it, but that would just be unnecessary extra work. The comments in code tell why the span is unused, it's a span of `$var` literally, which is lost for `tt` variables because their tokens are outputted directly, but kept for other variables which are outputted as [groups](https://doc.rust-lang.org/nightly/proc_macro/struct.Group.html) and `sp` is kept as the group's span. Closes rust-lang#2887
Configuration menu - View commit details
-
Copy full SHA for 540d474 - Browse repository at this point
Copy the full SHA 540d474View commit details -
Rollup merge of rust-lang#78621 - solson:inline, r=m-ou-se
Inline Default::default() for atomics Functions like `AtomicUsize::default()` are not cross-crate inlineable before this PR ([see assembly output here](https://play.rust-lang.org/?version=stable&mode=release&edition=2018&gist=e353321766418f759c69fb141d3732f8)), which can lead to unexpected performance issues when initializing a large array using this function, e.g. as seen [here](https://github.com/spacejam/sled/blob/d513996a85875be8c813fd0e30a548b89682289a/src/histogram.rs#L53) which should turn into a simple loop writing zeroes but doesn't. r? @m-ou-se
Configuration menu - View commit details
-
Copy full SHA for 97678b8 - Browse repository at this point
Copy the full SHA 97678b8View commit details