Update Clippy #83012

flip1995 · 2021-03-11T10:32:58Z

Bi-weekly Clippy sync.

…r=camsteffen added new lint `owned_to_owned` Adding new lint `owned_to_owned` Creating draft PR to have this looked over. I think this takes all advice I received into account. I did have to update the `redundant_clone` test to ignore this lint -- I felt that was the safest action. closes: rust-lang#6715 changelog: added new lint `implicit_clone`

…ype" ICE

Fix ICEs 6792 and 6793 fixes rust-lang#6792, fixes rust-lang#6793. r? `@matthiaskrgr` Fixes the ICEs by replacing `TyCtxt::type_of` with `TypeckResults::expr_ty`. changelog: none

Remove workspace and fix dogfood (again) changelog: none In response to rust-lang/rust-clippy#6733 (comment)

…ith the diagnostics convention of the rustc dev guide lint message should not start with uppercase letters lint messages should not have punctuation at the end of the last line https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure The test reads through all the .stderr files in the testsuit and checks lint messages that start with "help: ", "error: " etc. There is also an exception list for special messages that are deemed acceptable. changelog: make sure lint messages conform with the rustc dev guide and add test

…ssage

…_items` lint

tests: add test that roughly ensures that our lint messages conform with the diagnostics convention of the rustc dev guide lint message should not start with uppercase letters lint messages should not have punctuation at the end of the last line https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure The test reads through all the .stderr files in the testsuit and checks lint messages that start with "help: ", "error: " etc. There is also an exception list for special messages that are deemed acceptable. changelog: make sure lint messages conform with the rustc dev guide and add test

…olds the job limit and paths to the sources and log files

…o the source files of a warning into the lintcheck log This is more convenient when reviewing new lint warnings that popped up in the logs

Update Clippy Bi-weekly Clippy sync. r? `@Manishearth`

JohnTitor · 2021-03-11T23:12:35Z

Failed in rollup: #83038 (comment)
Looks like GHA wasn't triggered on this PR?
@bors r-

flip1995 · 2021-03-11T23:14:10Z

@bors rollup=iffy

flip1995 · 2021-03-11T23:17:23Z

    Checking clippy_lints v0.1.52 (/checkout/src/tools/clippy/clippy_lints)
error: unnecessary parentheses around pattern
   --> src/tools/clippy/clippy_lints/src/loops/manual_memcpy.rs:206:13
    |
206 |         let (Sugg::NonParen(s) | Sugg::MaybeParen(s) | Sugg::BinOp(_, s)) = &self.0;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
    |
    = note: `-D unused-parens` implied by `-D warnings`
error: aborting due to previous error

error: could not compile `clippy_lints`

Uh that looks weird. In the rust->Clippy sync direction, I was told to add them. Seems like something changed here and those parentheses aren't necessary anymore? Just seems like unfortunate timing. I will fix this tomorrow.

This will be removed in the next sync, once beta is at 1.52. Until then this hack avoids to put `cfg(bootstrap)` into Clippy.

flip1995 · 2021-03-12T14:36:31Z

@Manishearth This should now be ready. 99d0519 fixed the issue. I could've also fixed it by putting #[cfg(bootstrap)] in the code, but I wanted to avoid this in Clippy.

Manishearth · 2021-03-12T15:32:43Z

@bors r+

Good call

bors · 2021-03-12T15:32:44Z

📌 Commit 99d0519 has been approved by Manishearth

Update Clippy Bi-weekly Clippy sync. r? `@Manishearth`

Rollup of 6 pull requests Successful merges: - rust-lang#82984 (Simplify ast block lowering) - rust-lang#83012 (Update Clippy) - rust-lang#83020 (Emit the enum range assumption if the range only contains one element) - rust-lang#83037 (Support merge_functions option in NewPM since LLVM >= 12) - rust-lang#83052 (updated vulnerable deps) - rust-lang#83059 (Allow configuring `rustdoc --disable-minification` in config.toml) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2021-03-13T04:38:32Z

⌛ Testing commit 99d0519 with merge 4d76b4c...

anall and others added 30 commits February 26, 2021 19:13

added new lint implicit_clone

3d3cfd3

Add missing diagnostic item Symbols

2b3a731

new lint: iter_count

51617b8

allow clippy::iter_count

7223ee6

lint for into_iter().count()

204b279

move lints() to iter_count.rs

9958af4

return when the ty doesn't have len()

cc2b000

remove if_chain

8bae279

receive iter method name as an argument

77907e6

export derefs_to_slice from methods module

c297174

remove pub(crate)

6041365

Use TypeckResults::expr_ty instead of TyCtxt::type_of to fix "Not a t…

bdeec5d

…ype" ICE

Add test for ICE 6793

e51bb0e

Auto merge of rust-lang#6812 - Y-Nak:fix-6792, r=matthiaskrgr

6971b0d

Fix ICEs 6792 and 6793 fixes rust-lang#6792, fixes rust-lang#6793. r? `@matthiaskrgr` Fixes the ICEs by replacing `TyCtxt::type_of` with `TypeckResults::expr_ty`. changelog: none

Auto merge of rust-lang#6802 - camsteffen:dogfood-fix, r=llogiq

abd2c7e

Remove workspace and fix dogfood (again) changelog: none In response to rust-lang/rust-clippy#6733 (comment)

fix clippy lint warnings

5370576

update the lint messages and tests

8eb2bd1

disable lint_message_convention test inside the rustc test suite

e107b65

change some lint messages and remove old entries from the ignorelist

e00b1cc

lintcheck: update logs

24460f7

use different example (C-like) for valid capitalized start of lint me…

ebc5c8f

…ssage

Fix false positives on procedural macros of `missing_inline_in_public…

da3a573

…_items` lint

Fix manual_map: do not expand macros in suggestions

a3278a1

lintcheck: refactor: introduce a basic LintcheckConfig struct which h…

d931d1b

…olds the job limit and paths to the sources and log files

lintcheck: don't run clippy in parallel by default

2d9932d

lintcheck: uses consts for clippy driver and cargo clippy paths

e338604

lintcheck: put the full paths (target/lintcheck/sources/<crate>...) t…

1b1ed93

…o the source files of a warning into the lintcheck log This is more convenient when reviewing new lint warnings that popped up in the logs

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 11, 2021

Rollup merge of rust-lang#83012 - flip1995:clippyup, r=Manishearth

766c875

Update Clippy Bi-weekly Clippy sync. r? `@Manishearth`

JohnTitor mentioned this pull request Mar 11, 2021

Rollup of 13 pull requests #83038

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 11, 2021

flip1995 closed this Mar 11, 2021

flip1995 reopened this Mar 11, 2021

This comment has been minimized.

Sign in to view

Y-Nak mentioned this pull request Mar 12, 2021

associated type missing default rust-lang/rust-clippy#6882

Closed

flip1995 added 3 commits March 12, 2021 15:30

Merge commit '6ed6f1e6a1a8f414ba7e6d9b8222e7e5a1686e42' into clippyup

fb311e1

Update Cargo.lock

412ebc3

Clippy: HACK! Fix bootstrap error

99d0519

This will be removed in the next sync, once beta is at 1.52. Until then this hack avoids to put `cfg(bootstrap)` into Clippy.

flip1995 force-pushed the clippyup branch from f6bb462 to 99d0519 Compare March 12, 2021 14:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2021

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 12, 2021

Rollup merge of rust-lang#83012 - flip1995:clippyup, r=Manishearth

f55a5a3

Update Clippy Bi-weekly Clippy sync. r? `@Manishearth`

Dylan-DPC-zz mentioned this pull request Mar 12, 2021

Rollup of 8 pull requests #83063

Closed

JohnTitor mentioned this pull request Mar 13, 2021

Rollup of 6 pull requests #83067

Merged

bors merged commit 7f319c7 into rust-lang:master Mar 13, 2021

rustbot added this to the 1.52.0 milestone Mar 13, 2021

flip1995 deleted the clippyup branch March 13, 2021 12:53

ghost mentioned this pull request Mar 15, 2021

Add a parse_sess_created callback to rustc_interface::interface::Config #82900

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy #83012

Update Clippy #83012

flip1995 commented Mar 11, 2021

JohnTitor commented Mar 11, 2021

flip1995 commented Mar 11, 2021

flip1995 commented Mar 11, 2021

This comment has been minimized.

flip1995 commented Mar 12, 2021

Manishearth commented Mar 12, 2021

bors commented Mar 12, 2021

bors commented Mar 13, 2021

Update Clippy #83012

Update Clippy #83012

Conversation

flip1995 commented Mar 11, 2021

JohnTitor commented Mar 11, 2021

flip1995 commented Mar 11, 2021

flip1995 commented Mar 11, 2021

This comment has been minimized.

flip1995 commented Mar 12, 2021

Manishearth commented Mar 12, 2021

bors commented Mar 12, 2021

bors commented Mar 13, 2021