Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Add missing throws to PHPDoc #26

Closed
wants to merge 216 commits into from

Conversation

saphaljha
Copy link
Owner

Original Pull Request

magento#20050

Description (*)

Document the InputException thrown https://github.com/magento/magento2/blob/2.3.0/app/code/Magento/Catalog/Model/CategoryLinkRepository.php#L81

Fixed Issues (if relevant)

  1. CategoryLinkReposity does not list all possible exceptions magento/magento2#20037: CategoryLinkReposity does not list all possible exceptions

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

SeruyV and others added 30 commits November 13, 2018 16:58
…en editing the billing address of an order in the admin
…en editing the billing address of an order in the admin
…results in the element's state being changed
 - Merge Pull Request magento#19690 from thomas-blackbird/magento2:2.2-develop-PR-port-19617
 - Merged commits:
   1. 63d5da5
…terface magento#19693

 - Merge Pull Request magento#19693 from JeroenVanLeusden/magento2:2.2-develop-PR-port-18832
 - Merged commits:
   1. 07aa7d5
   2. 851708f
…#19199

 - Merge Pull Request magento#19199 from gwharton/magento2:2.2-develop-homepagelogoclickable
 - Merged commits:
   1. bd3cb9b
   2. 2ad7fd6
…date changes as per travis change session message
…results in the element's state being changed
magento-engcom-team and others added 27 commits January 3, 2019 09:18
…box magento#19056

 - Merge Pull Request magento#19056 from speedy008/magento2:fix-issue-19052
 - Merged commits:
   1. 9e1459a
# Conflicts:
#	app/code/Magento/SalesRule/Test/Mftf/Data/SalesRuleData.xml
#	app/code/Magento/SalesRule/Test/Mftf/Page/AdminCartPriceRuleEditPage.xml
 - merged latest code from mainline branch
[TSG] Backporting for 2.2 (pr66) (2.2.8)
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - magento#19889: [Backport]Fix issue 19507 - Frontend Minicart dropdown alignment issue  (by @speedy008)
 - magento#19910: [Backport] fixed Notification page Select Visible items issue  (by @shikhamis11)
 - magento#19928: [Backport] [Review] Integration tests for not allowed review submission (by @eduard13)
 - magento#19056: Fix issue 19052- Position order showing before the text box (by @speedy008)
 - magento#19989: [Backport] Fixed magento#19605 Don't static compile disabled modules (by @shikhamis11)


Fixed GitHub Issues:
 - magento#19507: Frontend Minicart dropdown alignment issue (reported by @speedy008) has been fixed in magento#19889 by @speedy008 in 2.2-develop branch
   Related commits:
     1. afba6e4

 - magento#19285: On Notification page Select All and Select Visible both works same (reported by @hellotaran) has been fixed in magento#19910 by @shikhamis11 in 2.2-develop branch
   Related commits:
     1. 9804da7
     2. c4bf9d2
     3. 9e37895
     4. b39a770
     5. c0ea9e4
     6. 0810a4a
     7. a69b2d9
     8. 598881f
     9. 84461c5
     10. 8397479
     11. 3808266
     12. 108b190
     13. 25a6c2e
     14. 4fd5c95
     15. 2c55232

 - magento#19052: Position order showing before the text box (reported by @Dharmeshvaja91) has been fixed in magento#19056 by @speedy008 in 2.2-develop branch
   Related commits:
     1. 9e1459a

 - magento#19605: Don't static compile disabled modules (reported by @joshuaadickerson) has been fixed in magento#19989 by @shikhamis11 in 2.2-develop branch
   Related commits:
     1. 1f5ec6f
     2. 484b79a
     3. d291cf3
Fixed magento#19780
Incorrect class name on Orders and returns page.
Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout
…pping in shipping address label whenever any user adding new shipping address in mobile view in checkout magento#20083

 - Merge Pull Request magento#20083 from GovindaSharma/magento2:2.2-develop-PR-port-19926
 - Merged commits:
   1. 39a7405
   2. 8ecf64f
… Value for 'product_type' attribute contains incorrect value magento#20081

 - Merge Pull Request magento#20081 from GovindaSharma/magento2:2.2-develop-PR-port-19408
 - Merged commits:
   1. 192a429
…rns page. magento#20080

 - Merge Pull Request magento#20080 from shikhamis11/magento2:2.2-develop-PR-port-19784
 - Merged commits:
   1. 9480a63
… Value for 'product_type' attribute contains incorrect value magento#20081
…pping in shipping address label whenever any user adding new shipping address in mobile view in checkout magento#20083
[EngCom] Public Pull Requests - 2.2-develop
@saphaljha saphaljha closed this Feb 6, 2019
@saphaljha saphaljha deleted the 2.2-develop-PR-port-20050 branch February 6, 2019 14:56
saphaljha pushed a commit that referenced this pull request Jul 22, 2021
MC-41904 Fix HTML tags not properly nested/closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.