This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Don't panic while searching gateway #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbstp Thank you for merging this! I would appreciate it if you cut a new release. 🙂 |
|
done |
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
May 3, 2023
## Issue Addressed #4171 ## Proposed Changes Through [this PR](sbstp/rust-igd#56) in rust-igd, `igd` v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking. ## Additional Info No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes. sbstp/rust-igd@v0.11.1...v0.12.1
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
May 3, 2023
## Issue Addressed #4171 ## Proposed Changes Through [this PR](sbstp/rust-igd#56) in rust-igd, `igd` v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking. ## Additional Info No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes. sbstp/rust-igd@v0.11.1...v0.12.1
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
## Issue Addressed sigp#4171 ## Proposed Changes Through [this PR](sbstp/rust-igd#56) in rust-igd, `igd` v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking. ## Additional Info No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes. sbstp/rust-igd@v0.11.1...v0.12.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_gateway()panics because ofattohttpc::get()would panics with something invalid urls.This PR makes
search_gateway()log errors instead of panic so that users identify the cause of errors.