Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update igd to v0.12.1 #4257

Closed
wants to merge 1 commit into from

Conversation

ackintosh
Copy link
Member

@ackintosh ackintosh commented May 2, 2023

Issue Addressed

#4171

Proposed Changes

Through this PR in rust-igd, igd v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking.

Additional Info

No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes.

sbstp/rust-igd@v0.11.1...v0.12.1

@ackintosh
Copy link
Member Author

I don't have permission to assign reviewers, tagging @AgeManning @divagant-martian @michaelsproul .

@AgeManning
Copy link
Member

bors r+

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label May 3, 2023
bors bot pushed a commit that referenced this pull request May 3, 2023
## Issue Addressed

#4171

## Proposed Changes

Through [this PR](sbstp/rust-igd#56) in rust-igd, `igd` v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking.

## Additional Info

No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes.

sbstp/rust-igd@v0.11.1...v0.12.1
@michaelsproul
Copy link
Member

bors r-

@bors
Copy link

bors bot commented May 3, 2023

Canceled.

@michaelsproul
Copy link
Member

re-batching

bors r+

bors bot pushed a commit that referenced this pull request May 3, 2023
## Issue Addressed

#4171

## Proposed Changes

Through [this PR](sbstp/rust-igd#56) in rust-igd, `igd` v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking.

## Additional Info

No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes.

sbstp/rust-igd@v0.11.1...v0.12.1
@bors
Copy link

bors bot commented May 3, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Update igd to v0.12.1 [Merged by Bors] - Update igd to v0.12.1 May 3, 2023
@bors bors bot closed this May 3, 2023
@ackintosh ackintosh deleted the bump-rust-igd branch May 3, 2023 13:35
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
## Issue Addressed

sigp#4171

## Proposed Changes

Through [this PR](sbstp/rust-igd#56) in rust-igd, `igd` v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking.

## Additional Info

No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes.

sbstp/rust-igd@v0.11.1...v0.12.1
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

sigp#4171

## Proposed Changes

Through [this PR](sbstp/rust-igd#56) in rust-igd, `igd` v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking.

## Additional Info

No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes.

sbstp/rust-igd@v0.11.1...v0.12.1
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

sigp#4171

## Proposed Changes

Through [this PR](sbstp/rust-igd#56) in rust-igd, `igd` v0.12.1 no longer panics if there is an issue while searching for a gateway. So updating igd makes lighthouse emit a helpful log instead of panicking.

## Additional Info

No CHANGELOG exists in rust-igd. 👀 Here is the commit history between v0.11.1 and v0.12.1. No breaking changes.

sbstp/rust-igd@v0.11.1...v0.12.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants