Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: change build to autogen version info #1062

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Dec 12, 2023

This may help in streamlining releases in the future, but it's up to opinion on operations.
It also makes it easier for users to see if they are using a build installed from source.

@jpivarski @lobis

@lgray lgray closed this Dec 12, 2023
@lgray lgray reopened this Dec 12, 2023
@lgray
Copy link
Contributor Author

lgray commented Dec 12, 2023

@jpivarski some of these failures seem ~persistent but are obviously not related.

Anyway - this one isn't super high priority. Decided to propose the option to y'all!

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had been avoiding this on principle, but I can no longer remember the reason why. Since I can't remember it, I guess it's time to give in and let hatch-vcs manage the version.py.

We should merge this after the 5.2.0 release.

Thanks!

@lgray
Copy link
Contributor Author

lgray commented Jan 3, 2024

@jpivarski reminder of this one, but again low priority.

@jpivarski
Copy link
Member

Yeah, I know. Okay, I'll try it out now.

jpivarski added a commit that referenced this pull request Jan 3, 2024
@jpivarski jpivarski enabled auto-merge (squash) January 3, 2024 22:01
@jpivarski jpivarski merged commit 63bb43f into scikit-hep:main Jan 3, 2024
20 checks passed
@jpivarski
Copy link
Member

It worked, and I don't see any reason to not use hatch-vcs. Awkward Array uses hatchling as well, though its release process is more complex because there's an awkward-cpp part that absolutely must be versioned by hand. (Its version number is essentially an ABI between the two parts of the project, so we want to control that.)

lobis added a commit that referenced this pull request Jan 22, 2024
* origin/main: (41 commits)
  chore: hatch-vcs generates 'version.py'; add it to .gitignore
  docs: add bnavigator as a contributor for test (#1087)
  feat: support for writing hist derived profiles (#1000)
  feat: add the ability to read RNTuple alias columns (#1004)
  chore: update pre-commit hooks (#1082)
  docs: fix ReadTheDocs documentation (#1084)
  chore: update pre-commit hooks (#1073)
  chore(deps): bump actions/upload-artifact from 3 to 4 (#1071)
  chore(deps): bump actions/download-artifact from 3 to 4 (#1072)
  build: change build to autogen version info (#1062)
  chore: remove src/uproot/version.py (for #1062).
  The next release will be 5.2.1.
  add known_base_form option so that opening root files can be avoided for mature analyses (#1077)
  test: fsspec cache (#1075)
  test: xrootd server fixture (#1076)
  The next release will be 5.2.0.
  fix: correct typo in fsspec globbing (#1067)
  chore(deps): bump actions/setup-python from 4 to 5 (#1059)
  The next release will be 5.2.0rc5.
  fix: dask distributed fsspec issue (#1065)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants