feat: supply a pre-calculated base form to avoid file opening #1077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
known_base_form
option (awkward.forms.Form | None
) touproot.dask
so that opening root files at the client can be avoided for mature analyses where the base forms of all files are well known. This is pertinent for root tree with large numbers of keys like NanoAOD.Right now it is mutually exclusive with
open_files=True
, since it brings no advantage in that case.An initial implementation is included.
I tested the speedup with the following code:
Which on a arm64 macbook pro with SSD gives about a 6x speedup. The gain will be enormous when using xrootd.