test: xrootd server fixture #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
approved these changes
Dec 21, 2023
I've writen a couple of fixtures and they all follow the same pattern (this one is actually based on what's used in fsspec-xrootd). My understanding is that fixtures have this structure so that setup / cleanup can be defined in a single function. First the fixture method is run until the yield (setup), then the test code is ran, then the code after the yield (cleanup) is ran. |
lobis
added a commit
that referenced
this pull request
Jan 22, 2024
* origin/main: (41 commits) chore: hatch-vcs generates 'version.py'; add it to .gitignore docs: add bnavigator as a contributor for test (#1087) feat: support for writing hist derived profiles (#1000) feat: add the ability to read RNTuple alias columns (#1004) chore: update pre-commit hooks (#1082) docs: fix ReadTheDocs documentation (#1084) chore: update pre-commit hooks (#1073) chore(deps): bump actions/upload-artifact from 3 to 4 (#1071) chore(deps): bump actions/download-artifact from 3 to 4 (#1072) build: change build to autogen version info (#1062) chore: remove src/uproot/version.py (for #1062). The next release will be 5.2.1. add known_base_form option so that opening root files can be avoided for mature analyses (#1077) test: fsspec cache (#1075) test: xrootd server fixture (#1076) The next release will be 5.2.0. fix: correct typo in fsspec globbing (#1067) chore(deps): bump actions/setup-python from 4 to 5 (#1059) The next release will be 5.2.0rc5. fix: dask distributed fsspec issue (#1065) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pytest fixture for xrootd server which can be used to serve files locally over xrootd. We might want to switch to use this for all xrootd tests to avoid networking / server issues.
I updated one xrootd test to use this new fixture.
I also renamed the old "server" fixture to "http_server" since now we have more than one server fixture.